Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: V 1.2 Slider with images overlays everything else? #4802

Closed
uofmmike opened this issue Dec 16, 2015 · 3 comments
Closed

bug: V 1.2 Slider with images overlays everything else? #4802

uofmmike opened this issue Dec 16, 2015 · 3 comments
Milestone
1.2.1

Comments

@uofmmike
Copy link
Contributor

Type: bug

Platform: all

Slider in ionic#v1.2.0-nightly-1839 appears to not overlay correctly.

Issue seen here:
http://codepen.io/uofmmike/pen/pggqbB

(and inline here)

<html ng-app="ionicApp">

<head>
  <meta charset="utf-8">
  <meta name="viewport" content="initial-scale=1, maximum-scale=1, user-scalable=no, width=device-width">

  <title>Ionic Custom Loading Bar</title>

  <link href="//code.ionicframework.com/nightly/css/ionic.css" rel="stylesheet">
  <script src="//code.ionicframework.com/nightly/js/ionic.bundle.js"></script>

</head>

<body ng-controller="MainCtrl">

  <ion-view view-title="Dashboard">
    <ion-content class="padding">
      <div class=" card">
        <h4>Layered behind :(</h4>
      </div>
      <div class='card'>
        <ion-slides options="">
          <ion-slide-page>
            <img src='https://upload.wikimedia.org/wikipedia/commons/thumb/6/6e/Golde33443.jpg/398px-Golde33443.jpg'>
          </ion-slide-page>
          <ion-slide-page>
            <img src='https://upload.wikimedia.org/wikipedia/commons/thumb/6/6e/Golde33443.jpg/398px-Golde33443.jpg'>
          </ion-slide-page>
        </ion-slides>
      </div>
    </ion-content>
  </ion-view>


</body>

</html>

```</span>

<span is-issue-template></span>
@mlynch mlynch added this to the 1.2.1 milestone Dec 16, 2015
@mlynch mlynch closed this as completed in ff752f7 Dec 16, 2015
@mlynch
Copy link
Contributor

mlynch commented Dec 16, 2015

Should be fixed in master and will be in 1.2.1 this week. Mind letting me know how that works?

@uofmmike
Copy link
Contributor Author

Thanks for the reply @mlynch!

Don't know if i've got a config wrong, now, i'm not seeing anything in the pen I provided earlier.

I replaced the images and followed the docs at :http://ionicframework.com/docs/nightly/api/directive/ionSlides/

Now I'm not seeing anything from the slider?
http://codepen.io/uofmmike/pen/pggqbB

@uofmmike
Copy link
Contributor Author

Looks like it's an issue within the card, outside of the card the slider is fine, inside there appears to be no height. I'll create a separate issue for a new patch.

#4881 Linked issue

@uofmmike uofmmike mentioned this issue Dec 30, 2015
Closed
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.1
Development

No branches or pull requests
2 participants
@mlynch @uofmmike