Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show author e-mail in commit diff #2035

Closed
karasz opened this issue Nov 25, 2015 · 8 comments
Closed

Show author e-mail in commit diff #2035

karasz opened this issue Nov 25, 2015 · 8 comments
Labels
🔨 enhancement Make it better, faster status: needs feedback Tell me more about it
Milestone
0.8.0

Comments

@karasz
Copy link

karasz commented Nov 25, 2015

Is it possible to show somehow in gogs the git headers of a commit like Author, Commiter with emails?
@unknwon
Copy link
Member

unknwon commented Nov 25, 2015

Hi,

What and how to get git headers you are saying for a commit? Any examples?

@unknwon unknwon added the status: needs feedback Tell me more about it label Nov 25, 2015
@unknwon unknwon added this to the 0.8.0 milestone Nov 25, 2015
@karasz
Copy link
Author

karasz commented Nov 25, 2015

Hi,
the date is already there in newSignatureFromCommitline, in sig.Email. You just have to display it in the commit page. Here is an example:
screenshot

@unknwon
Copy link
Member

unknwon commented Nov 25, 2015

Thanks for the info.

But Gogs already displays author, commit, tree, parent. Which one you think is missing?

@karasz
Copy link
Author

karasz commented Nov 25, 2015

Just the emails of the author and commiter.

@unknwon
Copy link
Member

unknwon commented Nov 25, 2015

OK, I see.

@unknwon unknwon added 🔨 enhancement Make it better, faster and removed status: needs feedback Tell me more about it labels Nov 25, 2015
@unknwon unknwon changed the title git headers Show author e-mail in commit diff Nov 25, 2015
unknwon added a commit that referenced this issue Dec 9, 2015
@unknwon
#2035 Show author e-mail in commit diff
c3440c4
@unknwon unknwon added the status: needs feedback Tell me more about it label Dec 9, 2015
@unknwon
Copy link
Member

unknwon commented Dec 9, 2015

It is now possible in develop branch and https://try.gogs.io/unknwon/gogs/commit/6a5c87afdd32286cb1e8f92d330960f5f8641967

(email is hidden for non-login visitors)

@unknwon
Copy link
Member

unknwon commented Dec 9, 2015

image

@unknwon
Copy link
Member

unknwon commented Dec 12, 2015

Close as implemented.

@unknwon unknwon closed this as completed Dec 12, 2015
richmahn referenced this issue in unfoldingWord/dcs Jun 28, 2017
@iszla @lunny
Pagination on releases page (#2035)
3f90164 
* Added count to GetReleasesByRepoID so pagination will work

* Separated it out to a new function, can then also leave the API part unaffected

* Remove extra whitespace added in untouched function

* Added comment and corrected name in error handler

* Account for if the user is owner or not in the count

* Also check if repo is draft

* revert back to the correct count in the ReleasesToDisplay loop

* Fixed lint error regarding else with return statement

* Use Cond struct instead of string, corrected name in error handler

* Removed unused return variable names
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🔨 enhancement Make it better, faster status: needs feedback Tell me more about it
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
2 participants
@karasz @unknwon