Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Able to config fsck timeout #1943

Closed
rubenv opened this issue Nov 14, 2015 · 8 comments
Closed

Able to config fsck timeout #1943

rubenv opened this issue Nov 14, 2015 · 8 comments
Labels
🔨 enhancement Make it better, faster status: needs feedback Tell me more about it
Milestone
0.8.0

Comments

@rubenv
Copy link
Contributor

rubenv commented Nov 14, 2015

It seems that the timeout for fsck is 60 seconds.

One of the git repositories I'm hosting is 9 gigabytes, which causes the health check to be marked as failed (sometimes, not all the time, depends on the system load).

Could we increase this timeout slightly for health checks?
@unknwon
Copy link
Member

unknwon commented Nov 14, 2015

Hmm... yeah, should be able to add a config option for this.

@unknwon unknwon added the 🔨 enhancement Make it better, faster label Nov 14, 2015
@unknwon unknwon added this to the 0.7.x milestone Nov 14, 2015
@unknwon unknwon modified the milestones: 0.7.x, 0.8.0 Nov 21, 2015
@unknwon unknwon changed the title Fsck timeout too low Able to config fsck timeout Nov 21, 2015
unknwon added a commit that referenced this issue Dec 9, 2015
@unknwon
#1943 Able to config fsck timeout
718d3ae
@unknwon
Copy link
Member

unknwon commented Dec 9, 2015

Now on develop branch, you can use https://github.com/gogits/gogs/blob/develop/conf/app.ini#L299 to config timeout, the syntax is

A duration string is a possibly signed sequence of decimal numbers, each with optional fraction and a unit suffix, such as "300ms", "-1.5h" or "2h45m". Valid time units are "ns", "us" (or "µs"), "ms", "s", "m", "h".

@unknwon unknwon added the status: needs feedback Tell me more about it label Dec 9, 2015
@rubenv
Copy link
Contributor Author

rubenv commented Dec 9, 2015

That's perfect. Thanks a lot!

@linquize
Copy link
Contributor

What happen when timeout? Kill git fsck?

@unknwon
Copy link
Member

unknwon commented Dec 10, 2015

@linquize yes

@linquize
Copy link
Contributor

When and where to do fsck in gogs?

@unknwon
Copy link
Member

unknwon commented Dec 10, 2015

Admin monitoring panel.

@unknwon
Copy link
Member

unknwon commented Dec 12, 2015

Close as implemented.

@unknwon unknwon closed this as completed Dec 12, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🔨 enhancement Make it better, faster status: needs feedback Tell me more about it
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
3 participants
@rubenv @linquize @unknwon