Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Set spinner icon via $ionicConfigProvider #3877

Closed
mikejpeters opened this issue Jun 2, 2015 · 3 comments
Closed

feat: Set spinner icon via $ionicConfigProvider #3877

mikejpeters opened this issue Jun 2, 2015 · 3 comments
Assignees
@mhartington

Comments

@mikejpeters
Copy link

Type: feat

Platform: all

It would be useful to be able to configure the default spinner icon via the $ionicConfigProvider service (e.g. you want all platforms to use the bubbles icon).
This was referenced Jun 2, 2015
Closed
Closed
@jimthedev
Copy link

This is exactly what I am looking for. Thank you. Would this need an associated test?

@mhartington mhartington self-assigned this Jun 8, 2015
@mhartington
Copy link
Member

I like this idea, I'll review the PR. Thanks @mikejpeters

perrygovier pushed a commit that referenced this issue Jun 12, 2015
@mikejpeters @perrygovier
feat(spinner): Allow ionSpinner default to be set by ionicConfigProvi…
cf338cf 
…der Closes #3877
@perrygovier
Copy link
Contributor

added in cf338cf

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mhartington mhartington

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@jimthedev @perrygovier @mhartington @mikejpeters