Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: feat: Disable inherit item height in collection-repeat with grid view. #3387

Closed
Fulkman opened this issue Mar 24, 2015 · 3 comments
Closed
Milestone

Comments

@Fulkman
Copy link

Fulkman commented Mar 24, 2015

Type: bug

Platform: all

Is there any way to make this work? (workaround?)
http://jsfiddle.net/npb8omsz/1/

I want to item which 'item-height' set to a value to obey that height.
Now items in a 'row' inherit 'item-height' from item in first column and ignore it's own height.

@Fulkman Fulkman changed the title feat: Disable inherit item height in collection-repeat with grid view. bug: feat: Disable inherit item height in collection-repeat with grid view. Mar 24, 2015
@perrygovier
Copy link
Contributor

It's not really that items are not being sized correctly, but that rows are taking the height of the first item in the row, and the items are being covered up by subsequent rows.

@ajoslin is going to take a look and see if we can get rows to take the height of the tallest item in that row without too much of a performance hit.

Note, this will mean that each row will take the height of the tallest item in that row. They wont gravitate upwards like in masonry.

@perrygovier perrygovier added this to the 1.0.0-rc2 milestone Mar 24, 2015
@Fulkman
Copy link
Author

Fulkman commented Mar 24, 2015

Thank you for the quick reply.

It is exactly as you say. Solution that you propose is the most acceptable.
I'm fully aware of masonry and i didn't expect that kind of behavior.

@Fayozjon
Copy link

Tomasz

http://control-intern-managerial.ro/utrader-instaforex

24.03.2015, 13:23, "Tomasz Pietrzak" notifications@github.com:Is there any way to make this work? (workaround?)

I want to item which 'item-height' set to a value to obey that height.
Now items in a 'row' inherit 'item-height' from item in first column and ignore it's own height.

—Reply to this email directly or .

@perrygovier perrygovier modified the milestones: 1.0.0-rc2, 1.0.0-rc3 Mar 30, 2015
@ajoslin ajoslin closed this as completed in 40bedd7 Apr 6, 2015
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants