New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: controllerAs syntax in ion-view #3058
Comments
👍 |
👍 |
still using the temporary solution... |
Would be great if the |
@elebetsamer Same with me! I spent an hour trying to make controllerAs syntax with Ionic. Even I am following john papa's style guide! But what about when using es6? His style guide has minor issues with respect to es6? |
@SiddharthaRRamesh I'm not crossing that bridge yet. Think I'm going to wait for angular 2 and ionic 2 before worrying about it. |
@elebetsamer, @SiddharthaRRamesh, Yes, I was following john papa's fabulous angular style guide, too. Only to find out |
@SiddharthaRRamesh I use ES6 with ionic too. To circumvent this issue, I injected My code looks like this: class LoginController {
constructor($scope) {
$scope.ctrl = this;
}
// some method definitions...
}
LoginController.$inject = ['$scope']; |
Just sent PR #3651 to fix this issue. Hopefully it will be merged soon :) |
@urish you are everywhere !!!!! ;) |
Same with you @thaiat :) p.s. here is the repro codepen with the fixed ionic version: http://codepen.io/anon/pen/QbbQPo |
+1 Would love for this to be resolved! |
+1 for this being resolved! Thanks to @urish hopefully this will be resolved soon 👍 |
+1 would be great to make this work |
+1 looking forward to having this added as well |
+1 please make it happend |
+1 |
1 similar comment
+1 |
Very annoying bug, please fix this! |
+1 |
Please see us @Ionitron |
I cant believe that something trivial as controllerAs is not working. |
@perrygovier can you please look into merging this? it's a small change, and will help many people. Thanks! |
+1 |
1 similar comment
+1 |
definitely need this to be fixed, mustn't be that complicated to fix since the controller: 'controller as vm' syntax is working fine! |
@clmntfrndz the fix is already available in #3651, but hasn't been merged in yet |
Any expected timeline of when this will be merged in yet and fixed? |
Looks like it's set for 1.1 release |
Please make that this happen |
It is not fixed in the 1.1 release :( |
Why is the fix not being merged? well, I guess we'll have to patch it ourselves... |
@telemakhos please check out the PR, I have addressed this.
|
@mhartington ah! ok! I think that'll do the trick |
+1 |
Type: bug
Platform: all
There is still an issue with the controllerAs syntax and ion-view (beta 14)
this issue #2499 is still happening
here is a repro codepen: http://codepen.io/thaiat/pen/zxPMbL
if you change line 16 to the commented part, it's working
The issue is related to views in state
The text was updated successfully, but these errors were encountered: