Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest SCAYT copies id of editor element to the iframe #108

Closed
Reinmar opened this issue Sep 30, 2015 · 8 comments
Closed

Latest SCAYT copies id of editor element to the iframe #108

Reinmar opened this issue Sep 30, 2015 · 8 comments
Labels
type:bug

Comments

@Reinmar
Copy link
Contributor

Reinmar commented Sep 30, 2015

  1. Open CKEditor official sample (the one shipped in a package).
  2. Enable SCAYT.
  3. Weird dashed border appears around the content.

Tuns out this is caused by SCAYT adding id editor to the iframe element used by the editor. This is incorrect because this id is already used by element from which the editor was created. Duplicating id may lead to unpredictable issues in integrations.
@Reinmar
Copy link
Contributor Author

Reinmar commented Sep 30, 2015

This issue was reproduced with 62461da. Everything works fine in 6b3f5a8 which is used by CKE 4.5.3.

@WebSpellChecker
Copy link
Collaborator

It is known behaviour. Thank you for reporting it. We're in progress to resolve this problem. We'll let you know the status of the issue on next Monday (19th of October, 2015)

@mlewand
Copy link
Contributor

mlewand commented Oct 21, 2015

Any ideas on when we can expect it to be fixed?

@WebSpellChecker
Copy link
Collaborator

We plan to update SCAYT plugin by the end of this week.

KremYura added a commit that referenced this issue Oct 25, 2015
@KremYura
#108 SCAYT 3 Plugin for CKEditor: SCAYT copies id of editor element t…
ac633a1 
…o the iframe / Removed id copying / Normalized container getter
@WebSpellChecker
Copy link
Collaborator

Fixed with ac633a1. This is not a final commit we plan to publish for CKEditor 4.5.5. Will keep you updated.

@Tade0
Copy link

Tade0 commented Nov 24, 2015

This error does occur anymore. Tested in 54fcc98.

@WebSpellChecker
Copy link
Collaborator

Fixed with ac633a1. Closed.

@WebSpellChecker
Copy link
Collaborator

The fix has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Reinmar @Tade0 @mlewand