Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCAYT's spans leak into the clipboard and after pasting #104

Closed
Reinmar opened this issue Aug 4, 2015 · 5 comments
Closed

SCAYT's spans leak into the clipboard and after pasting #104

Reinmar opened this issue Aug 4, 2015 · 5 comments
Labels

Comments

@Reinmar
Copy link
Contributor

Reinmar commented Aug 4, 2015

I've been definitely able to reproduce this issue with Firefox, but I think that it may be also reproducible on other browsers.

To test:

  1. Open http://cdn-source.ckeditor.com/4.5.1/standard-all/samples/
  2. Type random letters in few words in the content.
  3. Enable SCAYT. Incorrect words should be underlined.
  4. Select the content by mouse or keyboard (but not by CTRL+A which somehow removes the spans).
  5. Copy that content.
  6. Paste it to a sample without ACF like http://cdn-source.ckeditor.com/4.5.1/standard-all/samples/old/magicline/magicline.html
  7. See that pasted text includes spans and they are visible in the output:
<h1><span class="scayt-misspell-word" data-scayt-lang="en_US" data-scayt-word="Hddello">Hddello</span> <span class="scayt-misspell-word" data-scayt-lang="en_US" data-scayt-word="wddorld">wddorld</span>!</h1>

<p>I&#39;m andd insddtance of <a href="http://ckeditor.com">CKEditor</a>.</p>

Note that depending on how the content was selected some spans disappear and some other not.

The expected behaviour is that:

  1. Spans are removed before they copy takes place. This is the preferred solution as it prevents those spans leaking anywhere (e.g. to an editor which doesn't have SCAYT plugin enabled).
  2. Spans are removed on paste. This is a bit worse solution, because SCAYT plugin may not be enabled in certain editor and then spans won't be filtered out.
@Reinmar
Copy link
Contributor Author

Reinmar commented Aug 4, 2015

Reported in http://dev.ckeditor.com/ticket/13607.

@Reinmar
Copy link
Contributor Author

Reinmar commented Aug 4, 2015

Note – on Chrome and Safari it may happen that these spans are copied to but are filtered by the paste filter. Since the paste filter may be disabled or configured differently, this would be still a bug.

@WebSpellChecker
Copy link
Collaborator

We're in progress to review the benavior of with enable allowContent option. We'll get back with the results on Wednesday (August 12).

@WebSpellChecker
Copy link
Collaborator

We confirm the issue. It has been reported into our internal bug tracking system. Our Web Team currently is working on the solution. We're on the investigation stage and notify you when the status of the issue is changed.

@WebSpellChecker
Copy link
Collaborator

Please be informed that the fix for the issue has been released and merged to the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant