Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize by calling window.getComputedStyle once #81

Merged
merged 2 commits into from Dec 7, 2015
Merged

Optimize by calling window.getComputedStyle once #81

merged 2 commits into from Dec 7, 2015

Conversation

mbonaci
Copy link
Contributor

@mbonaci mbonaci commented Dec 7, 2015

Although called on a single element, getComputedStyle forces layout thrashing/reflow: https://gist.github.com/paulirish/5d52fb081b3570c81e3a

@mbonaci
Optimize by calling window.getComputedStyle once
e01cf11 
Although called on a single element, getComputedStyle forces layout thrashing/reflow: https://gist.github.com/paulirish/5d52fb081b3570c81e3a
@mbonaci
Missing comma
116ca51 
Damn!
@etpinard
Copy link
Contributor

etpinard commented Dec 7, 2015

@mbonaci 🍻 Thanks for doing this.

etpinard added a commit that referenced this pull request Dec 7, 2015
@etpinard
Merge pull request #81 from mbonaci/patch-1
ca7c598 
Optimize by calling window.getComputedStyle once
@etpinard etpinard merged commit ca7c598 into plotly:master Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mbonaci @etpinard