Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using JsonCreator still causes invalid path references in JsonMappingException #844

Closed
tea-dragon opened this issue Jun 24, 2015 · 1 comment

Comments

@tea-dragon
Copy link
Contributor

as much as I appreciate #801, it only address some of the cases.

for instance, the same issue occurs when buffering "regular" properties, and "any" properties.

Additionally, the error handling for creator.build() (ie. two lines down), seems incorrect. I suspect it should use the same handling as it does in later parts of the code for the same method -- otherwise it erroneously blames a specific creator property that may have done nothing wrong other than be last.

Same things apply to the mostly identical method deserializeUsingPropertyBasedWithUnwrapped. Let me know if you need a PR for this one, although I feel like the detailed description and links should make it easy enough to understand.

@cowtowncoder
Copy link
Member

Either way is fine, it's only matter of how fast things get done. Description is fine and I'll get to address these when I get a chance. Reviewing PRs takes is faster if you have time to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants