Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MESOS: Add pod resource request support #17054

Merged
merged 1 commit into from Nov 13, 2015
Merged

MESOS: Add pod resource request support #17054

merged 1 commit into from Nov 13, 2015

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Nov 10, 2015

  • add request support to LimitPodCPU and LimitPodMem, basically filling in default values or cutting off with minimal values if no valid request values are provided by the user.
  • for the moment match the limits with the offers (see TODO below)

TODO:

@sttts sttts self-assigned this Nov 10, 2015
@sttts sttts added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. area/platform/mesos team/mesosphere labels Nov 10, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/L

@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 10, 2015
@sttts sttts changed the title WIP/MESOS: Add resource requests support WIP/MESOS: Add pod resource request support Nov 10, 2015
@k8s-bot
Copy link

k8s-bot commented Nov 10, 2015

GCE e2e test build/test passed for commit c4ff9df921cc8075a70cb4a1cb45c277a8388933.

@k8s-bot
Copy link

k8s-bot commented Nov 10, 2015

GCE e2e build/test failed for commit 347811bd0c5e989c930b78a12cd3178fc648d479.

@sttts sttts closed this Nov 10, 2015
@sttts sttts reopened this Nov 10, 2015
@sttts sttts changed the title WIP/MESOS: Add pod resource request support MESOS: Add pod resource request support Nov 10, 2015
@sttts
Copy link
Contributor Author

sttts commented Nov 10, 2015

@k8s-bot test this please

@k8s-bot
Copy link

k8s-bot commented Nov 10, 2015

GCE e2e test build/test passed for commit 347811bd0c5e989c930b78a12cd3178fc648d479.

@sttts sttts changed the title MESOS: Add pod resource request support WIP/MESOS: Add pod resource request support Nov 10, 2015
@sttts sttts mentioned this pull request Nov 10, 2015
Closed
jdef
jdef reviewed Nov 10, 2015
View reviewed changes
contrib/mesos/pkg/scheduler/resource/resource.go
func CPUForPod(pod *api.Pod, defaultLimit CPUShares) CPUShares {
return PodCPULimit(pod) + CPUShares(unlimitedCountainerNum(pod, api.ResourceCPU))*defaultLimit
// CPUForPod computes the limits from the spec plus the default CPU limit difference for unlimited containers
func CPUForPod(pod *api.Pod, defaultLimit CPUShares) (request CPUShares, limit CPUShares, modified bool, err error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request, limit CPUShares

@jdef
Copy link
Contributor

jdef commented Nov 10, 2015

minor comments, otherwise looks good

@k8s-bot
Copy link

k8s-bot commented Nov 11, 2015

GCE e2e test build/test passed for commit a13eb9547b285482357ef5209ad100e8477c4ff8.

@k8s-bot
Copy link

k8s-bot commented Nov 11, 2015

GCE e2e test build/test passed for commit 2576b1d7ad1e8044bdc3c60eb8bc6cf1ab1b8b61.

@k8s-github-robot
Copy link

Continuous integration appears to have missed, closing and re-opening to trigger it

@sttts
Copy link
Contributor Author

sttts commented Nov 12, 2015

@k8s-bot test this please

@k8s-github-robot
Copy link

PR changed after LGTM, removing LGTM.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2015
@k8s-bot
Copy link

k8s-bot commented Nov 12, 2015

GCE e2e test build/test passed for commit 03494b712897bc2f2a7e6bf735823703290f2b06.

@k8s-bot
Copy link

k8s-bot commented Nov 12, 2015

GCE e2e build/test failed for commit b1c66df54aae04a1bd150b44ec1419d80446eee9.

@k8s-bot
Copy link

k8s-bot commented Nov 12, 2015

GCE e2e test build/test passed for commit a3f02cd.

@sttts sttts added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2015
@k8s-github-robot
Copy link

Continuous integration appears to have missed, closing and re-opening to trigger it

@karlkfi karlkfi mentioned this pull request Nov 12, 2015
Merged
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Nov 13, 2015

GCE e2e test build/test passed for commit a3f02cd.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Nov 13, 2015
Merge pull request #17054 from mesosphere/sttts-set-pod-resources
6ef6b9e 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit 6ef6b9e into kubernetes:master Nov 13, 2015
@karlkfi karlkfi deleted the sttts-set-pod-resources branch November 13, 2015 18:10
sttts pushed a commit to mesosphere-backup/kubernetes that referenced this pull request Nov 16, 2015
@sttts
Merge pull request kubernetes#17054 from mesosphere/sttts-set-pod-res…
bf1ecaa 
…ources

Auto commit by PR queue bot
sttts pushed a commit to mesosphere-backup/kubernetes that referenced this pull request Nov 30, 2015
@sttts
Merge pull request kubernetes#17054 from mesosphere/sttts-set-pod-res…
8c5468a 
…ources

Auto commit by PR queue bot
s-urbaniak pushed a commit to mesosphere-backup/kubernetes that referenced this pull request Dec 10, 2015
Merge pull request kubernetes#17054 from mesosphere/sttts-set-pod-res…
dcc1bcc 
…ources

Auto commit by PR queue bot
jdef pushed a commit to mesosphere-backup/kubernetes that referenced this pull request Jan 25, 2016
Merge pull request kubernetes#17054 from mesosphere/sttts-set-pod-res…
4b5a0f2 
…ources

Auto commit by PR queue bot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sttts sttts

Labels
area/platform/mesos lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sttts @k8s-github-robot @k8s-bot @jdef @k8s-teamcity-mesosphere @googlebot