Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added simple showModal() overload #954

Merged
merged 1 commit into from Oct 19, 2015
Merged

added simple showModal() overload #954

merged 1 commit into from Oct 19, 2015

Conversation

enchev
Copy link
Contributor

@enchev enchev commented Oct 19, 2015

Now you can do:

        var p = new Page();
        var ai = new ActivityIndicator();
        ai.busy = true
        p.content = ai;
        p.showModal();

        setTimeout(function () { p.closeModal(); }, 1000);

@hamorphis
Copy link
Contributor

👍

1 similar comment
@vakrilov
Copy link
Contributor

👍

@ns-bot ns-bot added cla: yes and removed cla: no labels Oct 19, 2015
enchev pushed a commit that referenced this pull request Oct 19, 2015
Merge pull request #954 from NativeScript/show-modal
b84a5c4 
added simple showModal() overload
@enchev enchev merged commit b84a5c4 into master Oct 19, 2015
@enchev enchev mentioned this pull request Oct 19, 2015
Closed
@enchev enchev deleted the show-modal branch October 19, 2015 08:33
@ns-bot
Copy link

ns-bot commented Oct 19, 2015

Test FAILed.

@alexrainman
Copy link

I still thinking this need to be added to Dialogs module including some parameters to set the overlay mode opacity. Anyway, i wish you make it work this way :)

@alexrainman
Copy link

This loading wheel will be available from view-model? I guess it is not merged yet because app is crashing as some function is not found.

@enchev enchev added this to the 1.5 milestone Nov 4, 2015
@lock
Copy link

lock bot commented Aug 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes done feature
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@enchev @hamorphis @vakrilov @ns-bot @alexrainman