Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.30 Error in Page Navigating Events order! #789

Closed
NathanaelA opened this issue Sep 21, 2015 · 2 comments
Closed

1.30 Error in Page Navigating Events order! #789

NathanaelA opened this issue Sep 21, 2015 · 2 comments
Assignees
Milestone

Comments

@NathanaelA
Copy link
Contributor

Man, v1.3 is just causing me all sorts of issues. As a work around to #779, I had to move the ShowModal code into the NavigatedTo event from the loaded event on iOS. So that the page would be setup properly before I called the ShowModal on the page. Well, guess what; on Android the onNavigatingTo actually fires BEFORE the pageLoaded event during startup. So now my code that does the initialization on my main screen so that the showModal can work properly isn't ran before it tries calling the showModal. Argh!

We need to get this fixed; in no cases should the onNavigatedTo event fire before the pageLoaded event. Please note this as far as I can tell ONLY occurs on the initial application bootup of the main screen. The events are in the correct order during the normal usage of the application.

@hamorphis hamorphis self-assigned this Nov 2, 2015
@hamorphis hamorphis added this to the 1.5 milestone Nov 3, 2015
hamorphis added a commit that referenced this issue Nov 3, 2015
hamorphis added a commit that referenced this issue Nov 4, 2015
@hamorphis hamorphis added ready for test TSC needs to test this and confirm against live production apps and automated test suites done and removed in progress ready for test TSC needs to test this and confirm against live production apps and automated test suites labels Nov 4, 2015
@hamorphis
Copy link
Contributor

After merging the Page Navigation Transitions(#1473) pull request into the master branch, the page lifecycle is now the following on both platforms.

  • navigatingTo event is raised
  • loaded event is raised
  • the page becomes frame.currentPage
  • navigatedTo event is raised

Also, in case you need to show modals in iOS, you should be doing it from the navigatedTo event.

@lock
Copy link

lock bot commented Aug 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants