This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
test: fix TestSocketActivation on systemd-v219 #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alban
force-pushed
the
alban/test-socket-activation
branch
from
ecad657
to
358222b
Compare
|
rebased. |
| @@ -86,9 +86,14 @@ func TestSocketActivation(t *testing.T) { | |||
|
|
|||
| rnd := r.Int() | |||
|
|
|||
| // Write unit files directly to /run/systemd/system because systemd-v219 does | |||
There was a problem hiding this comment.
This comment is a bit confusing. I would write something like:
Write unit files directly to runtime system units directory (/run/systemd/system) to avoid calling LinkUnitFiles - it is buggy in systemd v219 as it does not work with absolute paths.
|
I'm not fond of cluttering host directories with our testing stuff, but we were interacting with host systemd anyway. One nit, otherwise LFAD. |
alban
force-pushed
the
alban/test-socket-activation
branch
from
358222b
to
3c8b762
Compare
|
@krnowak Thanks. Updated. |
krnowak
added a commit
that referenced
this pull request
Nov 23, 2015
test: fix TestSocketActivation on systemd-v219
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1739