kvm: flannel networking #1563
kvm: flannel networking #1563
Conversation
|
What I miss is "follow up TODO list"
|
jonboulle
added
needs/some-changes
area/networking
and removed
area/networking
needs/review
labels
| Mask: net.IPMask(n.runtime.Mask), | ||
| }, chain); err != nil { | ||
| return nil, err | ||
| time.Sleep(time.Second / 2) // HACKHACKHACK - without this delay below changes in routes are not persistent |
There was a problem hiding this comment.
Have you been able to find out why this hack is needed?
There was a problem hiding this comment.
No, I had no time for this... Also I'm now on conference, so i'm less accessible...
There was a problem hiding this comment.
Today I can not reproduce this error, and also after removing call to Sleep - everything works flawlessly... without any additional work.
So at start this required 2 workdays to debug problem and find some workaround for problem which... magically disappeared.
|
@jellonek let us know when you might have time to work on this or if we can help shepherd it through |
|
This PR is follow up on #1530 so (hopefully) tomorrow i'll do rebase there after few hours. |
|
thanks! |
jellonek
force-pushed
the
jell/kvm-flannel
branch
2 times, most recently
from
09512fc
to
5492741
Compare
|
Both PRs are rebased. |
jellonek
force-pushed
the
jell/kvm-flannel
branch
from
5492741
to
7d3f9c7
Compare
|
@steveej can you review this? |
jellonek
force-pushed
the
jell/kvm-flannel
branch
from
7d3f9c7
to
525b845
Compare
jellonek
force-pushed
the
jell/kvm-flannel
branch
from
525b845
to
df0c175
Compare
|
@steveej Could You look at this? |
| } | ||
| } | ||
|
|
||
| return "", fmt.Errorf("pod has no default network!") |
There was a problem hiding this comment.
This would be the case if --net=none is chosen, or are there other cases? Do we warn the user at this point?
Making sure: does the kvm flavor load the default-restricted network if the user passes in other network names?
|
It should be rebased again, now that #1530 is merged. |
| func (t testNetDescriber) Mask() net.IP { return t.mask } | ||
| func (t testNetDescriber) IfName() string { return t.ifName } | ||
| func (t testNetDescriber) IPMasq() bool { return t.ipMasq } | ||
| func (t testNetDescriber) HostIP() net.IP { return t.hostIP } |
There was a problem hiding this comment.
WRT my previous comment: could this be used instead of Gateway()?
jellonek
force-pushed
the
jell/kvm-flannel
branch
from
df0c175
to
2c3d334
Compare
|
@steveej Your comments are interesting (and I have to address them, but in separate issue IMO) but are disconnected from this PR. It's because this PR was based on #1530 where this comments would be more adequate. I'll make a separate PR with cleanup in kvm flavor (docstrings are outdated, |
|
ACK. If semaphoreci turns green so we know it doesn't break things we should merge it an iterate through the next PR(s) in short term. |
|
IMO yes. |
Based on #1530
Provides flannel networking support in kvm flavor.