Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Meteor 1.2 #16877

Merged
merged 1 commit into from Jul 28, 2015
Merged

Add support for Meteor 1.2 #16877

merged 1 commit into from Jul 28, 2015

Conversation

rclai
Copy link
Contributor

@rclai rclai commented Jul 24, 2015

This is a refactor to prepare for the upcoming Meteor 1.2 release as well as any preview versions up to that point.

The { isAsset: true } is backwards compatible, it's just that once 1.2 comes around, it will be required for those kinds of files.

See this issue for more details.

@cvrebert
Copy link
Collaborator

CC: @splendido @dandv for review

@cvrebert cvrebert added the meta label Jul 24, 2015
@cvrebert cvrebert added this to the v3.3.6 milestone Jul 24, 2015
@dandv
Copy link
Contributor

dandv commented Jul 28, 2015

LGTM

cvrebert added a commit that referenced this pull request Jul 28, 2015
@cvrebert cvrebert merged commit 335f486 into twbs:master Jul 28, 2015
@mdo mdo mentioned this pull request Jul 28, 2015
@rclai
Copy link
Contributor Author

rclai commented Jul 28, 2015

Thanks guys 😄

I'm guessing that you guys will also push out an Atmosphere update too based on your ship list?

@dandv
Copy link
Contributor

dandv commented Jul 28, 2015

We're waiting to hear from MDG on an issue with the Atmosphere publish bot, then @splendido will be able to trigger a push (thanks!).

@rclai
Copy link
Contributor Author

rclai commented Jul 28, 2015

Oh I see, cool.

@zimme
Copy link

zimme commented Sep 4, 2015

meteor admin maintainers twbs:bootstrap --add publishbot
and autopublish should be good to go again.

cc: @dandv

@rclai
Copy link
Contributor Author

rclai commented Sep 4, 2015

Before we do that, looks like we might need to revisit this again because { isAsset: true } is now deprecated. More details here.

Wondering if for maximum compatibility we should do something like:

if (api.addAssets) {
  // Use api.addAssets
} else {
  // Use api.addFiles with { isAsset: true }
}

@zimme
Copy link

zimme commented Sep 4, 2015

Oh yeah, it's api.addAssets() now IIRC.

@zimme
Copy link

zimme commented Sep 4, 2015

If we don't wanna set versionsFrom to 1.2 then that approach looks like it's the better one.

@dandv
Copy link
Contributor

dandv commented Sep 5, 2015

Just ran meteor admin maintainers twbs:bootstrap --add publishbot.

@splendido
Copy link
Contributor

Would this be just to let people use twbs:bootstrap@3.3.5 with newer meteor releases?

In version 4 it seems fonts won't be included anymore. See the output of meteor show --show-all twbs:bootstrap and #17318
I have no idea about the timeline for v4 and whether other 3.x.x versions will be released before it though...

@zimme
Copy link

zimme commented Sep 6, 2015

They have.a ship list for 3.3.6 so I guess at least that will nees for both current meteor and 1.2+

@rclai
Copy link
Contributor Author

rclai commented Sep 24, 2015

Guys, here's a new PR now that Meteor 1.2 is out.

@cvrebert cvrebert added the meteor label Feb 2, 2016
@dandv
Copy link
Contributor

dandv commented Jul 29, 2016

Is this still relevant now that Meteor can use npm packages directly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants