Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs falsely claim "not-allowed" cursor for labels inside fieldset.disabled #16630

Closed
Herst opened this issue Jun 12, 2015 · 6 comments
Closed

Docs falsely claim "not-allowed" cursor for labels inside fieldset.disabled #16630

Herst opened this issue Jun 12, 2015 · 6 comments
Labels
confirmed css docs
Milestone
v3.3.6

Comments

@Herst
Copy link
Contributor

Herst commented Jun 12, 2015

From http://getbootstrap.com/css/#checkboxes-and-radios:

To have the for the checkbox or radio also display a "not-allowed" cursor when the user hovers over the label, add the .disabled class to your .radio, .radio-inline, .checkbox, .checkbox-inline, or <fieldset>

(bold highlighting by me)

Either the doc is wrong or the theme is missing something but adding the disabled class to an encompassing fieldset makes no difference.

Testcase with comparison to the other methods leading to the wanted result: http://jsbin.com/kacawu/3/edit?html,output (Bootlint and HTML validator passed).
@patrickhlauke patrickhlauke self-assigned this Jun 12, 2015
@cvrebert
Copy link
Collaborator

In the fieldset case, it should be the disabled attribute, as opposed to the disabled class; see

bootstrap/less/forms.less

Line 262 in 5a8d014

// Apply same disabled cursor tweak as for inputs

@Herst
Copy link
Contributor Author

Herst commented Jun 12, 2015

@cvrebert Yes, but there are caveats as mentioned at http://getbootstrap.com/css/#forms-disabled-fieldsets

@cvrebert
Copy link
Collaborator

To further clarify, the disabled class has never been meant to be used on <fieldset>s.

@Herst
Copy link
Contributor Author

Herst commented Jun 12, 2015

OK, I just thought it might be useful for cross-browser compatibility.

In any case if you plan on mentioning the disabled attribute on fieldsets in the checkbox section of the docs maybe link then to the fieldset-disabled section as well so that people who might not read the whole manual are aware of possible issues when using that approach.

@patrickhlauke
Copy link
Member

So unless I'm missing something, this is a simple case of the docs needing a tweak, right? Rather than the CSS? /cc @cvrebert

@cvrebert
Copy link
Collaborator

@patrickhlauke Correct.

@kkirsche kkirsche mentioned this issue Jun 12, 2015
Merged
@patrickhlauke patrickhlauke removed their assignment Jun 15, 2015
@mdo mdo added this to the v3.3.6 milestone Jun 18, 2015
@mdo mdo mentioned this issue Jun 18, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed css docs
Projects
None yet
Milestone
v3.3.6
Development

No branches or pull requests
4 participants
@mdo @cvrebert @patrickhlauke @Herst