Use @carousel-control-font-size for in min-width sm #16975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix twbs#16973 As 30px was hard coded for the following attribute values: `width`, `height`, and `font-size`, I have used the same pixel formula for each of these three as the `@carousel-control-width` is a percent value not a pixel value in variables.less
Yup, it should. |
mdo
added a commit
that referenced
this pull request
Nov 13, 2015
Use @carousel-control-font-size for in min-width sm
Closed
|
Took care of the margin changes in 1565c11. |
krissihall
pushed a commit
to krissihall/bootstrap
that referenced
this pull request
Feb 24, 2016
* tag 'v3.3.6' of https://github.com/twbs/bootstrap: (356 commits) prep release grunt after version bump bump version grunt Updating "Reporting upstream browser bugs" for IE Docs: Add missing `tabindex="-1"` & `role="dialog"` to some `.modal`s Ensure proper z-indexing in input-groups Fix IE9 clickthru of carousel controls that @cvrebert lifestyle fixes twbs#17003 [v3] Use border-radius mixin in button-groups.less Follow up to twbs#16975 Run `grunt`. Update devDependencies. Update verb tenses to proper tense for feature deprecations Port 33103c0 to v3 Port 6f14f02 to v3 Add http://wkbug.com/150715 to Wall of Browser Bugs Add docs regarding .progress, inline style attrs, and CSP; closes twbs#17785 Run `grunt. ...
chiraggmodi
pushed a commit
to chiraggmodi/bootstrap
that referenced
this pull request
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16973
As 30px was hard coded for the following attribute values:
width,height, andfont-size, I have used the same pixel formula for each of these three as the@carousel-control-widthis a percent value not a pixel value in variables.lessIf
margin-topshould be calculated we can also do that with a(@carousel-control-font-size * -0.75)