Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.modal-header min-height formula is wrong #16769

Closed
bezenson opened this issue Jul 5, 2015 · 2 comments
Closed

.modal-header min-height formula is wrong #16769

bezenson opened this issue Jul 5, 2015 · 2 comments
Labels
css
Milestone
v3.3.6

Comments

@bezenson
Copy link

bezenson commented Jul 5, 2015

modals.less, line 82.

min-height: (@modal-title-padding + @modal-title-line-height);

First of all it returns not rounded value. Secondary if we not set title, header seems broken. Cross becomes near bottom border. I don't know, what was idea of this min-height, but I fixed it with this code:

min-height: round(@modal-title-padding * 2 + @font-size-h4 * @line-height-base);
@cvrebert cvrebert added the css label Jul 5, 2015
@cvrebert cvrebert changed the title Modal header min-height counting wrong .modal-header min-height formula is wrong Jul 5, 2015
@mdo
Copy link
Member

mdo commented Jul 6, 2015

Have a before/after example?

@bezenson
Copy link
Author

@mdo Nope, but you can do it yourself. Inspect modal title and remove it. You will see what is wrong

@mdo mdo added this to the v3.3.6 milestone Aug 5, 2015
@mdo mdo mentioned this issue Aug 5, 2015
Closed
@mdo mdo closed this as completed in 5758692 Aug 5, 2015
@kkirsche kkirsche mentioned this issue Feb 21, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css
Projects
None yet
Milestone
v3.3.6
Development

No branches or pull requests
3 participants
@mdo @cvrebert @bezenson