Fix border-radius not being set on 2 corners of vertical btn group #16684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this is correct that it was not being set, I did not notice any visible difference in Chrome on OS X when it is not set. Fixes twbs#16683
kkirsche
changed the title
|
Where do we stand with this PR? I don't recall seeing any example demos pointing out the problem, and it seems we need to revisit how we remove the rounded corners as opposed to resetting them? |
|
That would seem to be the case @mdo. I haven't been able to replicate the problem though I understand it theoretically should exists the image above would show. It seems to be inheriting the two corners. |
mdo
added a commit
that referenced
this pull request
Nov 9, 2015
Fix border-radius not being set on 2 corners of vertical btn group
Closed
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this is correct that it was not being set, I did not notice any visible difference in Chrome on OS X when it is not set.
Fixes #16683