Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes border around <select> caret in IE10+ #16529

Merged
merged 1 commit into from Jun 18, 2015
Merged

Removes border around <select> caret in IE10+ #16529

merged 1 commit into from Jun 18, 2015
+10 −2

Conversation

WonSong
Copy link

@WonSong WonSong commented May 24, 2015

Working example in JSbin. Open it using IE: http://jsbin.com/lapakociya/1/edit?html,css,output
Removes border around select caret. Fixes issue #16527

Before and After in IE:
image

@cvrebert cvrebert added the css label May 24, 2015
@cvrebert cvrebert changed the title Removes border around select caret in IE Removes border around <select> caret in IE10+ May 24, 2015
@cvrebert cvrebert mentioned this pull request May 25, 2015
Closed
cvrebert
cvrebert reviewed May 28, 2015
View reviewed changes
less/forms.less
@@ -132,6 +132,12 @@ output {
// Placeholder
.placeholder();

// Removes the border and background color around the caret in IE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"in IE10+"

@mdo mdo added this to the v3.3.6 milestone Jun 18, 2015
mdo added a commit that referenced this pull request Jun 18, 2015
@mdo
Merge pull request #16529 from WonSong/master
a89f00e 
Removes border around <select> caret in IE10+
@mdo mdo merged commit a89f00e into twbs:master Jun 18, 2015
mdo added a commit that referenced this pull request Jun 18, 2015
@mdo
Follow up to #16529 (remove select caret in IE10+)
df78c89 
- Update comment as recommended by @cvrebert
- Use `transparent` for `background-color` so we don't need to override that value again in the disabled state.
- Remove disabled changes.

/cc @WonSong
@mdo
Copy link
Member

mdo commented Jun 18, 2015

Applied @cvrebert's feedback and tweaked some stuff in df78c89.

This was referenced Jun 18, 2015
Closed
Closed
@kkirsche kkirsche mentioned this pull request Feb 21, 2016
Merged
@dependabot dependabot bot mentioned this pull request Mar 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
css
Projects
None yet
Milestone
v3.3.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WonSong @mdo @cvrebert