Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not always restart when inject an environment variable #1271

Closed
emerleite opened this issue Sep 3, 2015 · 3 comments
Closed

Do not always restart when inject an environment variable #1271

emerleite opened this issue Sep 3, 2015 · 3 comments
Assignees
@dnsaoki2
Labels
enhancement

Comments

@emerleite
Copy link

Should be a way to inject an environment variable without restart the application. For example, if your application can deal with new variables without restart, it avoid destroy and recreate all units again.

One possible solution is to have an option in tsuru.yml to prevent those restarts.
@fsouza
Copy link
Contributor

fsouza commented Sep 3, 2015

We could have a flag in env-set and env-unset, for example:

% tsuru env-set -a myapp NAME=VALUE --no-restart
% tsuru env-unset -a myapp OLDNAME=OLDVALUE --no-restart
% tsuru app-deploy -a myapp .

@guestisp
Copy link
Contributor

guestisp commented Sep 4, 2015

+1 for a flag.

@dnsaoki2 dnsaoki2 self-assigned this Nov 4, 2015
@emerleite
Copy link
Author

👍

emerleite added a commit to emerleite/tsuru-bluegreen that referenced this issue Feb 24, 2016
@emerleite
Do not restart units on env-set. Refs tsuru/tsuru#1271
a4f5837
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnsaoki2 dnsaoki2

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@emerleite @fsouza @guestisp @dnsaoki2