Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect is_deterministic for UUID #5092

Closed
VeXocide opened this issue Nov 14, 2015 · 5 comments
Closed

Incorrect is_deterministic for UUID #5092

VeXocide opened this issue Nov 14, 2015 · 5 comments
Assignees
Milestone

Comments

@VeXocide
Copy link
Member

We currently return deterministic::no in is_deterministic for r.uuid, see https://github.com/rethinkdb/rethinkdb/blob/next/src/rdb_protocol/terms/uuid.cc#L39.

Unfortunately it's no longer this simple now that we support version 5 UUIDs such as r.uuid("foo"), these are based on a namespace and SHA-1 hash and are deterministic.

@thelinuxlich
Copy link

Just stumbled upon this trying to update documents with r.uuid(string) :( :(

@danielmewes danielmewes added this to the 2.2.x milestone Nov 17, 2015
@danielmewes
Copy link
Member

We should obviously fix this. Looking at how is_deterministic works, it's probably going to be a very easy fix.

@danielmewes danielmewes self-assigned this Nov 17, 2015
@danielmewes
Copy link
Member

A fix is up in review 3345

@danielmewes danielmewes modified the milestones: 2.2.1, 2.2.x Nov 17, 2015
@danielmewes
Copy link
Member

Fixed in next cef5d65 and v2.2.x f1d53cd

@captainpete
Copy link
Contributor

Yes!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants