rgw: fail s3 POST auth if keystone not configured #3966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: ceph#10698 This fixes issue introduced in 8b3dfc9, where if user does not exist, we try keystone authentication. However, if keystone is not configured we justt fall through without failing. This would have failed later on due to bucket permissions, unless bucket had a public write permissions. Backports: Firefly Reported-by: Valery Tschopp <valery.tschopp@switch.ch> Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> Conflicts: src/rgw/rgw_rest_s3.cc
ghost
added
|
SUCCESS: the output of run-make-check.sh on centos-7 for 1b36f1d is http://paste2.org/m6BXhWnb |
Sent from
ghost
pushed a commit
that referenced
this pull request
Mar 16, 2015
rgw: fail s3 POST auth if keystone not configured Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10698
This fixes issue introduced in 8b3dfc9,
where if user does not exist, we try keystone authentication. However,
if keystone is not configured we justt fall through without failing.
This would have failed later on due to bucket permissions, unless bucket
had a public write permissions.
Backports: Firefly
Reported-by: Valery Tschopp valery.tschopp@switch.ch
Signed-off-by: Yehuda Sadeh yehuda@redhat.com
Conflicts:
src/rgw/rgw_rest_s3.cc