rgw: civetweb should use unique request id #4780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oritwas
force-pushed
the
wip-10295-firefly
branch
from
9bbe290
to
c83e655
Compare
|
good catch , fixed it |
max_req_id was moved to RGWRados and changed to atomic64_t. The same request id resulted in gc giving the same idtag to all objects resulting in a leakage of rados objects. It only kept the last deleted object in it's queue, the previous objects were never freed. Fixes: 10295 Backport: Hammer, Firefly Signed-off-by: Orit Wasserman <owasserm@redhat.com> (cherry picked from commit c262259) Conflicts: src/rgw/rgw_main.cc src/rgw/rgw_rados.h
oritwas
force-pushed
the
wip-10295-firefly
branch
from
c83e655
to
665a857
Compare
|
@oritwas looks good, maybe we should make some sanity check to validate it's actually working? |
|
run s3 tests all ok except version tests ----- Original Message -----
|
yehudasa
added a commit
that referenced
this pull request
Jun 2, 2015
rgw: civetweb should use unique request id Reviewd-by: Yehuda Sadeh <yehuda@rehat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/11720
max_req_id was moved to RGWRados and changed to atomic64_t.
The same request id resulted in gc giving the same idtag to all objects
resulting in a leakage of rados objects. It only kept the last deleted object in
it's queue, the previous objects were never freed.
Fixes: 10295
Backport: Hammer, Firefly
Signed-off-by: Orit Wasserman owasserm@redhat.com
(cherry picked from commit c262259)
Conflicts:
src/rgw/rgw_main.cc
src/rgw/rgw_rados.h