Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgw: check for timestamp for s3 keystone auth #3958

Merged
1 commit merged into from Mar 16, 2015
Merged

rgw: check for timestamp for s3 keystone auth #3958

1 commit merged into from Mar 16, 2015

Conversation

ghost
Copy link

@ghost ghost commented Mar 11, 2015

@theanalyst @ldachary
rgw: check for timestamp for s3 keystone auth
9074eb7 
This commit ensures that we check for timestamp of s3 request is within
acceptable grace time of radosgw
Addresses some failures in #10062
Fixes: #10062
Signed-off-by: Abhishek Lekshmanan <abhishek.lekshmanan@gmail.com>

(cherry picked from commit 4b35ae0)
@theanalyst
Copy link
Member

@dachary probably 8b3dfc9 should be superseded by the commit cbf0691 which fixes an issue introduced by the commit. So that should also make the backport

@valerytschopp
Copy link

I agree with @theanalyst the commit cbf0691 should be used, it fixes all the issues.

@ghost ghost added bug-fix rgw labels Mar 11, 2015
@ghost ghost added this to the firefly milestone Mar 11, 2015
@ghost
Copy link
Author

ghost commented Mar 11, 2015

@theanalyst @valerytschopp thanks for the quick review :-) I'll close this one since http://tracker.ceph.com/issues/10698 is the better solution( also added a note at http://tracker.ceph.com/issues/10062#note-14 )

@ghost ghost closed this Mar 11, 2015
@loic-bot
Copy link

SUCCESS: the output of run-make-check.sh on centos-7 for ae4cf8e is http://paste2.org/ncUA1Fdf

:octocat: Sent from GH.

@theanalyst
Copy link
Member

@dachary I guess cherry picking PRs #2993 and #3551 should close the entire thing

@ghost ghost reopened this Mar 11, 2015
@ghost
Copy link
Author

ghost commented Mar 11, 2015

I'll keep #2993 in this pull request. @theanalyst will you create a new pull request with #3551 backport ?

@ghost ghost changed the title s3-test failures using keystone authentication rgw: check for timestamp for s3 keystone auth Mar 11, 2015
@ghost ghost self-assigned this Mar 11, 2015
@theanalyst
Copy link
Member

sure, will do

@loic-bot
Copy link

SUCCESS: the output of run-make-check.sh on centos-7 for edb2ed9 is http://paste2.org/hOwe7X5t

:octocat: Sent from GH.

@theanalyst
Copy link
Member

@dachary created #3966 to backport #3551

ghost pushed a commit that referenced this pull request Mar 16, 2015
@ldachary
Merge pull request #3958 from dachary/wip-10062-firefly
66327d6 
rgw: check for timestamp for s3 keystone auth


Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
Reviewed-by: Abhishek Lekshmanan <abhishek.lekshmanan@ril.com>
Reviewed-by: Valery Tschopp <valery.tschopp@switch.ch>
@ghost ghost merged commit 66327d6 into ceph:firefly Mar 16, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix rgw
Projects
None yet
Milestone
firefly
3 participants
@theanalyst @valerytschopp @loic-bot