librados: Fix memory leak in python rados bindings #3935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A circular reference was inadvertently created when using the CFUNCTYPE binding for callbacks for the asynchronous i/o callbacks. This commit refactors the usage of the callbacks such that the Ioctx object does not have a class reference to the callbacks. Fixes: #10723 Backport: giant, firefly, dumpling Signed-off-by: Billy Olsen <billy.olsen@gmail.com> Reviewed-by: Dan Mick <dmick@redhat.com> Reviewed-by: Josh Durgin <jdurgin@redhat.com> (cherry picked from commit 60b019f)
|
SUCCESS: the output of run-make-check.sh on centos-7 for d1559e7 is http://paste2.org/AzcnVCVL |
Sent from 
|
http://tracker.ceph.com/issues/10775 should be backported at the same time as this (it fixes a bug in this patch) |
If we don't keep a reference to these, the librados aio calls will segfault since the python-level callbacks will have been garbage collected. Passing them to aio_create_completion() does not take a reference to them. Keep a reference in the python Completion object associated with the request, since they need the same lifetime. This fixes a regression from 60b019f. Fixes: #10775 Backport: dumpling, firefly, giant Signed-off-by: Josh Durgin <jdurgin@redhat.com> (cherry picked from commit 36d37aa)
|
@jdurgin thanks, the commit was added to this pull request |
|
SUCCESS: the output of run-make-check.sh on centos-7 for 2bed326 is http://paste2.org/Cy7nYhjc |
|
lgtm |
ghost
pushed a commit
that referenced
this pull request
Mar 16, 2015
Fix memory leak in python rados bindings Reviewed-by: Samuel Just <sjust@redhat.com> Reviewed-by: Josh Durgin <jdurgin@redhat.com>
ghost
merged commit 
ghost
changed the title
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A circular reference was inadvertently created when using the
CFUNCTYPE binding for callbacks for the asynchronous i/o callbacks.
This commit refactors the usage of the callbacks such that the
Ioctx object does not have a class reference to the callbacks.
Fixes: #10723
Backport: giant, firefly, dumpling
Signed-off-by: Billy Olsen billy.olsen@gmail.com
Reviewed-by: Dan Mick dmick@redhat.com
Reviewed-by: Josh Durgin jdurgin@redhat.com
(cherry picked from commit 60b019f)