crush: set_choose_tries = 100 for erasure code rulesets #3824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is common for people to try to map 9 OSDs out of a 9 OSDs total ceph cluster. The default tries (50) will frequently lead to bad mappings for this use case. Changing it to 100 makes no significant CPU performance difference, as tested manually by running crushtool on one million mappings. http://tracker.ceph.com/issues/10353 Fixes: #10353 Signed-off-by: Loic Dachary <ldachary@redhat.com> (cherry picked from commit 2f87ac8) Conflicts: src/erasure-code/lrc/ErasureCodeLrc.cc safely ignored because the file does not exist
|
SUCCESS: the output of run-make-check.sh on centos-centos7 for 3db33c1 is http://paste2.org/_G9n7Up7Y |
Sent from
ghost
pushed a commit
that referenced
this pull request
Mar 11, 2015
crush: set_choose_tries = 100 for erasure code rulesets Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
merged commit 
ghost
changed the title
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is common for people to try to map 9 OSDs out of a 9 OSDs total ceph
cluster. The default tries (50) will frequently lead to bad mappings for
this use case. Changing it to 100 makes no significant CPU performance
difference, as tested manually by running crushtool on one million
mappings.
http://tracker.ceph.com/issues/10353 Fixes: #10353
Signed-off-by: Loic Dachary ldachary@redhat.com
(cherry picked from commit 2f87ac8)
Conflicts:
src/erasure-code/lrc/ErasureCodeLrc.cc
safely ignored because the file does not exist