Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r.asc('foo') returns 'foo' #4951

Closed
neumino opened this issue Oct 14, 2015 · 4 comments
Closed

r.asc('foo') returns 'foo' #4951

neumino opened this issue Oct 14, 2015 · 4 comments
Labels
tp:bug
Milestone
2.2

Comments

@neumino
Copy link
Member

neumino commented Oct 14, 2015

It uses to throw an error in 2.0.

If r.asc is nested, I'll get the expected error

ASC may only be used as an argument to ORDER_BY.
@neumino
Copy link
Member Author

neumino commented Oct 14, 2015

Just to give a bit of context, I had a test in reqlite testing for the error using r.asc('foo'). I'm not sure anyone else will actually write this query.

@pritambaral
Copy link
Contributor

Bug introduced in 4d0a80e#diff-5f5f60e255e349a06cc62ee7c7fa20d2R84, and tracked to 2.1.5 through 1cd2122#diff-5f5f60e255e349a06cc62ee7c7fa20d2R117

Readying PR

pritambaral added a commit to pritambaral/rethinkdb that referenced this issue Oct 14, 2015
@pritambaral
Fix rethinkdb#4951
8e885af 
The bug got introduced in rethinkdb@4d0a80e and persisted through the file rewrite in rethinkdb@1cd2122
@danielmewes danielmewes added this to the 2.1.x milestone Oct 14, 2015
@coffeemug
Copy link
Contributor

Thank you @pritambaral! (Also we should add a test on this to polyglot tests)

@coffeemug
Copy link
Contributor

Also, /cc @Tryneus for completeness.

@mlucy mlucy closed this as completed in 74c80d9 Oct 26, 2015
mlucy added a commit that referenced this issue Oct 26, 2015
@mlucy
Merge pull request #4954 from pritambaral/patch-1
8bd570a 
Fix #4951
larkost pushed a commit that referenced this issue Oct 27, 2015
@pritambaral @larkost
Fix #4951
6ba46d2 
The bug got introduced in 4d0a80e and persisted through the rewrite in
1cd2122
@danielmewes danielmewes modified the milestones: 2.1.x, 2.2 Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tp:bug
Projects
None yet
Milestone
2.2
Development

No branches or pull requests
4 participants
@coffeemug @danielmewes @pritambaral @neumino