Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix behavior of or #4132

Closed
mlucy opened this issue Apr 27, 2015 · 3 comments
Closed

Fix behavior of or #4132

mlucy opened this issue Apr 27, 2015 · 3 comments
Labels
cp:reql tp:bug
Milestone
2.2

Comments

@mlucy
Copy link
Member

mlucy commented Apr 27, 2015

r(false).or(nil) should return nil (but r(nil).or(false) should continue to return false).
@mlucy mlucy added this to the 2.1-polish milestone Apr 27, 2015
@mlucy mlucy mentioned this issue Apr 27, 2015
Closed
@danielmewes
Copy link
Member

Actually even r.(nil).or(nil) returns false at the moment.

@thenightwassave
Copy link

@danielmewes
Just interesting, but reading the thread you linked me to in the other issue shows mlucy noticed that variation when you were discussing it over there (last line in comment): #3562 (comment)

@mlucy mlucy mentioned this issue Aug 15, 2015
Closed
eliangidoni added a commit to eliangidoni/rethinkdb that referenced this issue Oct 24, 2015
@eliangidoni
Fix for issue rethinkdb#4132
41a723f
eliangidoni added a commit to eliangidoni/rethinkdb that referenced this issue Oct 24, 2015
@eliangidoni
Fix for issue rethinkdb#4132
e115cd9
@mlucy
Copy link
Member Author

mlucy commented Nov 10, 2015

This is in next (the review was completed a while ago and I had just forgotten to merge it in).

@mlucy mlucy closed this as completed Nov 10, 2015
@mlucy mlucy mentioned this issue Nov 10, 2015
Closed
@danielmewes danielmewes modified the milestones: 2.2-polish, 2.2 Nov 11, 2015
@mlucy mlucy mentioned this issue Nov 26, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cp:reql tp:bug
Projects
None yet
Milestone
2.2
Development

No branches or pull requests
3 participants
@danielmewes @mlucy @thenightwassave