Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optarg to .changes to alter the limit of changes cached on server #3607

Closed
larkost opened this issue Jan 20, 2015 · 3 comments
Closed
Milestone

Comments

@larkost
Copy link
Collaborator

larkost commented Jan 20, 2015

The server will cache 100,000 changes before it starts forgetting newer changes and sending the client a warning message about this. However, that is a huge number and is impractical for some cases, such as:

  1. Testing: it takes many minutes to write that many changes to disk on some systems. So at the moment we are not able to test this every time.
  2. Cases where the documents may be large will cause the memory usage on the server to ballon, especially since we keep before and after.
  3. In some instances data that old might be worthless, so we are just making the client work harder when it has gotten behind.

So I would like to request an optarg to set the number of values to cache for this query. A compiled-in value has also been suggested, but for testing I eventually want to support running the suite on an already-installed version, making that a sub-optimal solution.

@danielmewes danielmewes added this to the subsequent milestone Jan 20, 2015
@larkost
Copy link
Collaborator Author

larkost commented May 11, 2015

Once this is done then the sub-test should be updated and enabled in test/rql_test/src/changefeeds/table.yaml

@danielmewes
Copy link
Member

Incidentally, such a parameter is part of the agreed upon proposal for #3471 .

Leaving this open as a separate issue because it's a different use case, but we'll likely solve both together.

@danielmewes danielmewes modified the milestones: 2.2-polish, subsequent May 11, 2015
@danielmewes
Copy link
Member

This parameter exists as changefeed_queue_size (not sure which commit added it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants