Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of protocol buffer data structures in query processing #4601

Closed
danielmewes opened this issue Jul 30, 2015 · 7 comments
Closed

Get rid of protocol buffer data structures in query processing #4601

danielmewes opened this issue Jul 30, 2015 · 7 comments
Assignees
Milestone

Comments

@danielmewes
Copy link
Member

@Tryneus had already started on this one.
I couldn't find an issue for this, so opening this for tracking purposes.

As a side-effect, we will discontinue support for the protocol buffer client protocol.

@larkost mentioned in #3664 (comment) that we also need to remove some protobuf tests for this.

@Tryneus
Copy link
Member

Tryneus commented Sep 14, 2015

This is up in review 3219.

@danielmewes
Copy link
Member Author

👏 🎉

@danielcompton
Copy link
Contributor

@Tryneus where are the reviews? Is that in a private review tool?

@Tryneus
Copy link
Member

Tryneus commented Sep 15, 2015

@danielcompton, yeah, it's just an internal review, and once it gets approved we'll merge it to next. If you're really curious, you can check out the branch in grey_no_term_storage (ignore the name, it was an iterative process).

@danielcompton
Copy link
Contributor

@Tryneus thanks, I was just curious what the review numbers meant.

@Tryneus
Copy link
Member

Tryneus commented Sep 28, 2015

The changes have been merged to next in commit 1cd2122. Will be in release 2.2.

@Tryneus Tryneus closed this as completed Sep 28, 2015
@danielmewes
Copy link
Member Author

👏 🎉 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants