Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"docker inspect -f dns" incompatibility between 1.8 and 1.9 #17680

Closed
bboreham opened this issue Nov 4, 2015 · 10 comments
Closed

"docker inspect -f dns" incompatibility between 1.8 and 1.9 #17680

bboreham opened this issue Nov 4, 2015 · 10 comments
Assignees
@calavera
Labels
kind/bug Bugs are bugs. The cause may or may not be known at triage time so debugging may be needed. priority/P0 Urgent: Security, critical bugs, blocking issues. drop everything until this issue is addressed.
Milestone
1.9.1

Comments

@bboreham
Copy link
Contributor

bboreham commented Nov 4, 2015

As noted in #17026,

docker inspect -f {{.HostConfig.Dns}} somecontainer

works in 1.8 (and earlier) and doesn't work in 1.9, while

docker inspect -f {{.HostConfig.DNS}} somecontainer

works in 1.9 and doesn't work in 1.8.

This is a pretty bad compatibility breakage for anyone with a script that fetches this setting.
Also I cannot see the change mentioned in the release notes.
@awh
Copy link

awh commented Nov 4, 2015

DnsOptions and DnsSearch are also affected; furthermore, 1.9 docker inspect still reports these values with the original 1.8 capitalisation.

@thaJeztah
Copy link
Member

Hm possibly related to #15566, #15567 #17284

/cc @calavera

@thaJeztah
Copy link
Member

oh, I see #17026 was mentioned in the description

@thaJeztah thaJeztah added the kind/bug Bugs are bugs. The cause may or may not be known at triage time so debugging may be needed. label Nov 4, 2015
@cpuguy83
Copy link
Member

cpuguy83 commented Nov 4, 2015

Thanks for reporting this.

@cpuguy83 cpuguy83 added this to the 1.9.1 milestone Nov 4, 2015
@cpuguy83
Copy link
Member

cpuguy83 commented Nov 4, 2015

Tentatively adding to 1.9.1

@icecrime icecrime added the priority/P0 Urgent: Security, critical bugs, blocking issues. drop everything until this issue is addressed. label Nov 6, 2015
@calavera calavera mentioned this issue Nov 6, 2015
Merged
@thaJeztah thaJeztah mentioned this issue Nov 9, 2015
Closed
@thaJeztah
Copy link
Member

This should be fixed by #17779

Thanks again for reporting @bboreham @awh !

@bboreham
Copy link
Contributor Author

The issue I meant to raise is that the case of the name changed, not how it behaves on an empty value.

So it is impossible to write a script inspecting the value (when it is non-empty) that works against both 1.8 and 1.9.

@thaJeztah
Copy link
Member

@bboreham IIUC, #17779 should fix that; @calavera can you confirm? Just in case..

@bboreham
Copy link
Contributor Author

My apologies; having tested again I see the problem only hits when the field is empty.

Looks fixed to me in 1.9.1, thanks!

@thaJeztah
Copy link
Member

Thanks for testing @bboreham, good to hear it's fixed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calavera calavera

Labels
kind/bug Bugs are bugs. The cause may or may not be known at triage time so debugging may be needed. priority/P0 Urgent: Security, critical bugs, blocking issues. drop everything until this issue is addressed.
Projects
None yet
Milestone
1.9.1
Development

No branches or pull requests
6 participants
@calavera @cpuguy83 @awh @icecrime @thaJeztah @bboreham