Windows: [TP4] Fix docker login #17738
Conversation
Signed-off-by: John Howard <jhoward@microsoft.com>
|
oh, cool! change sgtm |
|
That's weird, as far as I can tell it already is literally |
|
Which on Windows using cmd or PS will end up as an ansireader |
|
@cpuguy83 See https://github.com/docker/docker/blob/master/pkg/term/term_windows.go#L39 where it will be windows.ConsoleStreams() which in turn changes it to an AnsiReader at https://github.com/docker/docker/blob/master/pkg/term/windows/console.go#L17 |
|
@jhowardmsft Aah I see, that term.go is no being built on Windows. Ok, LGTM. |
|
LGTM |
Windows: [TP4] Fix docker login
|
@jhowardmsft Erm, added it to the 1.9.1 milestone, because it's a bug in general and it would be nice for people to get access to this soon. Think you're okay with that 😄 |
|
@thaJeztah Can it be both? |
|
@jhowardmsft unfortunately not, I tried that, but it's one milestone only, so I selected 1.9.1 to make sure it gets cherry-picked |
|
Looking forward to this fix |
|
I saw it mentioned elsewhere, but the workaround wasn't clear to me until I discovered it myself. |
tiborvass
added
status/5-cherry-pick
impact/changelog
and removed
status/5-cherry-pick
status/2-code-review
labels
the error that remains appears to be a choice of shell/go functions moby/moby#15272 moby/moby#17738 golang/go#11914
Signed-off-by: John Howard jhoward@microsoft.com
@thaJeztah Fixes #14336 and #14210. This allows interactive docker login to work again on Windows. Verified under cmd and PowerShell. Previously, it was impossible to type anything, it would hang on the username prompt. The only workaround was to control-C and type all the parameters on a single line.