Avoid panic on write after close in http #17634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,7 +63,9 @@ func (s *router) getContainersStats(ctx context.Context, w http.ResponseWriter, | |||
| w.Header().Set("Content-Type", "application/json") | |||
| out = w | |||
| } else { | |||
| out = ioutils.NewWriteFlusher(w) | |||
| wf := ioutils.NewWriteFlusher(w) | |||
There was a problem hiding this comment.
I wonder what does this mean :)
Why not
out = ioutils.NewWriteFlusher(w)
defer out.Close()
?
|
@stevvooe tests are failing |
stevvooe
force-pushed
the
avoid-panic-on-flush
branch
from
8281b87
to
1f7344d
Compare
| n, err = wf.w.Write(b) | ||
| wf.flushed = true |
There was a problem hiding this comment.
What is the reason for removing this here?
There was a problem hiding this comment.
(*WriteFlusher).Flush() sets it.
There was a problem hiding this comment.
This is calling (http.Flusher).Flush()
There was a problem hiding this comment.
I'm sorry, this is terrible code. Fixing now.
stevvooe
force-pushed
the
avoid-panic-on-flush
branch
3 times, most recently
from
13b4886
to
ca6bd7e
Compare
By adding a (*WriteFlusher).Close, we limit the Write calls to possibly deallocated http response buffers to the lifetime of an http request. Typically, this is seen as a very confusing panic, the cause is usually a situation where an http.ResponseWriter is held after request completion. We avoid the panic by disallowing further writes to the response writer after the request is completed. Signed-off-by: Stephen J Day <stephen.day@docker.com>
stevvooe
force-pushed
the
avoid-panic-on-flush
branch
from
ca6bd7e
to
ec2289b
Compare
|
LGTM |
1 similar comment
|
LGTM |
LK4D4
added a commit
that referenced
this pull request
Nov 3, 2015
Avoid panic on write after close in http
tiborvass
added
status/5-cherry-pick
impact/changelog
and removed
status/5-cherry-pick
status/2-code-review
labels
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding a (*WriteFlusher).Close, we limit the Write calls to possibly
deallocated http response buffers to the lifetime of an http request.
Typically, this is seen as a very confusing panic, the cause is usually a
situation where an http.ResponseWriter is held after request completion. We
avoid the panic by disallowing further writes to the response writer after the
request is completed.
Closes #17625.
Signed-off-by: Stephen J Day stephen.day@docker.com