Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn IPC unmount errors into warnings. #17554

Merged
merged 1 commit into from Nov 2, 2015
Merged

Turn IPC unmount errors into warnings. #17554

merged 1 commit into from Nov 2, 2015

Conversation

calavera
Copy link
Contributor

And do not try to unmount empty paths.
Because nobody should be woken up in the middle of the night for them.

Fixes #17550

Signed-off-by: David Calavera david.calavera@gmail.com

@calavera calavera mentioned this pull request Oct 30, 2015
Closed
@calavera calavera force-pushed the warm_ipc_unmounts branch 2 times, most recently from 703782a to 686599b Compare October 30, 2015 23:09
@calavera calavera added this to the 1.9.1 milestone Oct 30, 2015
@calavera
Turn IPC unmount errors into warnings.
a54d593 
And do not try to unmount empty paths.

Because nobody should be woken up in the middle of the night for them.

Signed-off-by: David Calavera <david.calavera@gmail.com>
@cpuguy83
Copy link
Member

LGTM.
I do wonder if daemon.Register should just call container.cleanup() rather than specifically looking for the ipc mounts.

@calavera
Copy link
Contributor Author

calavera commented Nov 2, 2015

I do wonder if daemon.Register should just call container.cleanup() rather than specifically looking for the ipc mounts.

container.cleanup makes assumptions that I don't think we want

@calavera calavera mentioned this pull request Nov 2, 2015
Merged
@LK4D4
Copy link
Contributor

LK4D4 commented Nov 2, 2015

LGTM

LK4D4 added a commit that referenced this pull request Nov 2, 2015
@LK4D4
Merge pull request #17554 from calavera/warm_ipc_unmounts
944ea31 
Turn IPC unmount errors into warnings.
@LK4D4 LK4D4 merged commit 944ea31 into moby:master Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
impact/changelog
Projects
None yet
Milestone
1.9.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@calavera @cpuguy83 @LK4D4 @tiborvass @GordonTheTurtle