Force IPC mount to unmount on daemon shutdown/init #17539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using `MNT_DETACH` to unmount the container's mqueue/shm mounts, force it... but only on daemon init and shutdown. This makes sure that these IPC mounts are cleaned up even when the daemon is killed. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
cleaner_ipc_unmount_handling
branch
from
bb42b44
to
78bd17e
Compare
|
LGTM |
1 similar comment
|
LGTM |
LK4D4
added a commit
that referenced
this pull request
Oct 30, 2015
Force IPC mount to unmount on daemon shutdown/init
tiborvass
added
status/5-cherry-pick
impact/changelog
and removed
status/5-cherry-pick
status/2-code-review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using
MNT_DETACHto unmount the container's mqueue/shmmounts, force it... but only on daemon init and shutdown.
This makes sure that these IPC mounts are cleaned up even when the
daemon is killed.