This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
stage1/init: only consider running from unit file when session leader #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This means that if a systemd unit file has a I guess it's a reasonable compromise. |
|
Maybe there should also be a way to explicitly set --keep-unit, for when the heuristics fail? |
| // int | ||
| // am_session_leader() | ||
| // { | ||
| // return (getsid(0) == getpid()); |
|
I think this is reasonable and I don't think we need a flag for |
This augments the heuristics used to err on the side of non-unit-file, but will still consider as run from a unit file when executed directly via systemd.service Exec* directives. With this change, interactive invocations of rkt on CoreOS cease passing --keep-unit to nspawn. Fixes #1664
|
I think this is good as it is. Do you think it is worth documenting in Advanced Unit File? Something like:
|
can't hurt |
iaguis
added a commit
that referenced
this pull request
Nov 2, 2015
…der_too stage1/init: only consider running from unit file when session leader
iaguis
added a commit
to iaguis/rkt
that referenced
this pull request
Nov 2, 2015
After rkt#1694, rkt needs to be the group leader in a systemd unit file to make unit file detection work. Add some documentation on the topic.
iaguis
added a commit
to iaguis/rkt
that referenced
this pull request
Nov 2, 2015
After rkt#1694, rkt needs to be the group leader in a systemd unit file to make unit file detection work. Add some documentation on the topic.
iaguis
added a commit
to iaguis/rkt
that referenced
this pull request
Nov 2, 2015
After rkt#1694, rkt needs to be the group leader in a systemd unit file to make unit file detection work. Add some documentation on the topic.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This augments the heuristics used to err on the side of non-unit-file,
but will still consider as run from a unit file when executed directly
via systemd.service Exec* directives.
With this change, interactive invocations of rkt on CoreOS cease passing
--keep-unit to nspawn.
Fixes #1664