Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabbing when editing a comment / issue #1824

Closed
ChangePlaces opened this issue Oct 23, 2015 · 5 comments
Closed

Tabbing when editing a comment / issue #1824

ChangePlaces opened this issue Oct 23, 2015 · 5 comments
Labels
💊 bug Something isn't working status: needs feedback Tell me more about it 💻 ui You ruined my eyes!
Milestone
0.7.x

Comments

@ChangePlaces
Copy link

When editing a comment or issue, if I tab, I'd like to be taken to the save button so I can then press spacebar and have the issue / comment update. However this doesn't happen. Tabbing takes me to the next comment save button instead! (0.6.9)
@unknwon
Copy link
Member

unknwon commented Oct 23, 2015

Thanks your feedback!

But I'm not quite sure which button is which, can you make a screenshot to illustrate?

@unknwon unknwon added the status: needs feedback Tell me more about it label Oct 23, 2015
@unknwon unknwon added this to the 0.7.0 milestone Oct 23, 2015
@ChangePlaces
Copy link
Author

editing-comment

When I press on the edit pen, I see this. Once typing inside this box, pressing tab doesn't take me to the 'save' button for this comment!

@unknwon
Copy link
Member

unknwon commented Oct 23, 2015

I see what is the problem now. 😅

@unknwon unknwon added 💊 bug Something isn't working 💻 ui You ruined my eyes! and removed status: needs feedback Tell me more about it labels Oct 23, 2015
@ChangePlaces
Copy link
Author

it's the same for the issue body edit and issue title edit as well.

@unknwon unknwon modified the milestones: 0.8.0, 0.7.0 Oct 24, 2015
@ChangePlaces ChangePlaces mentioned this issue Nov 10, 2015
Closed
makhov pushed a commit to makhov/gogs that referenced this issue Nov 11, 2015
gogs#1824 fixed
f9bb67b
makhov pushed a commit to makhov/gogs that referenced this issue Nov 11, 2015
gogs#1824 add tabindex
f52a436
makhov pushed a commit to makhov/gogs that referenced this issue Nov 11, 2015
issue gogs#1824 add tabindex
7835c22
@makhov makhov mentioned this issue Nov 11, 2015
Merged
@unknwon unknwon modified the milestones: 0.7.x, 0.8.0 Nov 11, 2015
unknwon added a commit that referenced this issue Nov 11, 2015
@unknwon
fix #1824 and fix #1917
908f292
@unknwon
Copy link
Member

unknwon commented Nov 11, 2015

You should now be able to use tab switch to buttons and press enter key to trigger click event on develop and https://try.gogs.io .

@unknwon unknwon added the status: needs feedback Tell me more about it label Nov 11, 2015
ethantkoenig added a commit to ethantkoenig/gogs that referenced this issue May 30, 2017
@ethantkoenig @appleboy
Update code.gitea.io/git (gogs#1824)
474d636 
* Update code.gitea.io/git

* Update function calls

* govendor fetch
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
💊 bug Something isn't working status: needs feedback Tell me more about it 💻 ui You ruined my eyes!
Projects
None yet
Milestone
0.7.x
Development

No branches or pull requests
2 participants
@ChangePlaces @unknwon