Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show current branch in commit overview #1572

Closed
pcsch opened this issue Sep 3, 2015 · 10 comments
Closed

Show current branch in commit overview #1572

pcsch opened this issue Sep 3, 2015 · 10 comments
Labels
🔨 enhancement Make it better, faster 💻 ui You ruined my eyes!
Milestone

Comments

@pcsch
Copy link

pcsch commented Sep 3, 2015

On the commit overview there is no indication for which branch the commits are (except for the url)

It would be nice to have something like the following
branchname

@unknwon unknwon added 🔨 enhancement Make it better, faster 💻 ui You ruined my eyes! labels Sep 3, 2015
@unknwon
Copy link
Member

unknwon commented Sep 3, 2015

Thanks your feedback!

@unknwon unknwon added this to the 0.7.0 milestone Sep 3, 2015
@pcsch
Copy link
Author

pcsch commented Sep 11, 2015

There is a similar feature I miss:
When viewing issues for a certain milestone I can't see what milestone (if any) I am viewing at.
GitHub doesn't have this feature either (but at least they show the milestone in the search field).
It would be nice to have some sort of indication that I'm looking at issues only for a certain milestone. 😄

PS: I don't know if this belongs here, if you want I can open a new issue.

@unknwon
Copy link
Member

unknwon commented Sep 11, 2015

When viewing issues for a certain milestone I can't see what milestone (if any) I am viewing at.

I'm not quite understand your request, but https://try.gogs.io/gogs/gogs/issues already has milestone filter.

@pcsch
Copy link
Author

pcsch commented Sep 11, 2015

Yes you are right, but unless I click on the milestone filter selector (the drop down menu) I don't see that there is a milestone filter applied. The same goes with the other filters.

What I meant was something at the top of the page that says something like "You are viewing issues for milestone xy". But I now think it would be better to show what filters are applied. Like for example do not only display the type of filter but also e.g. Milestone: xy as the text for the drop down selector. (see screenshot)
filter

This is no problem when I actively select a filter, because then I know that I am only looking at issues for a certain filter.
But if someone sends me a link to issues with a certain filter applied or if I leave the tab in my browser open and visit it later I don't see that there is a filter applied. It also helps to identify if you misclicked in the filter dropdown menu.

It would help me to recognise what I'm looking at more easily.

Edit: This is already done with branches at the default repository view.

@unknwon
Copy link
Member

unknwon commented Sep 11, 2015

Thanks your suggestion!

Currently, if you open https://try.gogs.io/gogs/gogs/issues?type=all&sort=&state=open&labels=0&milestone=46&assignee=0 , you will see that the issues are only showing the milestone with mile1. Label is working the same way.

However, your example screenshot has UI issues with screen in 1024*768, so the better solution is having a search box in Gogs UI as well(which is a completely new feature request and should open another issue)

@pcsch
Copy link
Author

pcsch commented Sep 11, 2015

you will see that the issues are only showing the milestone with mile1.

I see your point. But if I don't know if there are other milestones I still don't know if a filter is applied.

However, your example screenshot has UI issues with screen in 1024*768, so the better solution is having a search box in Gogs UI as well

I think you are right this could be a problem on small screens and a search box is a lot nicer in that case.

There already is an open feature request (issue #938) for a search box and I will post my thoughts there.

@unknwon
Copy link
Member

unknwon commented Sep 11, 2015

There already is an open feature request (issue #938) for a search box and I will post my thoughts there.

That would be the best. Thanks!

@unknwon unknwon modified the milestones: 0.7.x, 0.8.0 Nov 8, 2015
unknwon added a commit that referenced this issue Nov 10, 2015
@unknwon
Copy link
Member

unknwon commented Nov 10, 2015

Hi, i've pushed fix to develop branch and you can also test on https://try.gogs.io/gogs/gogs/commits/master

@pcsch
Copy link
Author

pcsch commented Nov 11, 2015

This works great and is exactly what I was looking for, thanks! 😄

@pcsch pcsch closed this as completed Nov 11, 2015
@unknwon
Copy link
Member

unknwon commented Nov 11, 2015

@mexthemax thanks your confirmation!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔨 enhancement Make it better, faster 💻 ui You ruined my eyes!
Projects
None yet
Development

No branches or pull requests

2 participants