Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong redirection after deleting system notice #1930

Closed
JokerQyou opened this issue Nov 12, 2015 · 2 comments
Closed

Wrong redirection after deleting system notice #1930

JokerQyou opened this issue Nov 12, 2015 · 2 comments
Labels
💊 bug Something isn't working status: needs feedback Tell me more about it
Milestone

Comments

@JokerQyou
Copy link

I noticed there are some system notices in the admin panel, all of them are about network error when updating mirror repos. So I deleted one of them, but after the deletion, gogs redirected me to the wrong position.
Let's say I have control of the domain a.com, and I use a.com/b/ for gogs, and I've configured gogs options as followed.

[server]
DOMAIN = a.com
ROOT_URL = https://a.com/b/

But after deleting the system notices (the deletion request wen well with https://a.com/b/admin/notices/{ID}/delete), gogs keeps redirecting me to /admin/notices, while the right URL would be https://a.com/b/admin/notices.

I think gogs should respond with full URL instead of only the path of target URL.

@unknwon unknwon added the 💊 bug Something isn't working label Nov 12, 2015
@unknwon unknwon added this to the 0.7.x milestone Nov 12, 2015
@unknwon
Copy link
Member

unknwon commented Nov 12, 2015

Hi! I've pushed fix to master, please help test again. (though I'm going to release new version now...)

@unknwon unknwon added the status: needs feedback Tell me more about it label Nov 12, 2015
@JokerQyou
Copy link
Author

Just upgraded to 0.7.6, fix confirmed.

richmahn referenced this issue in unfoldingWord/dcs Jun 13, 2017
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💊 bug Something isn't working status: needs feedback Tell me more about it
Projects
None yet
Development

No branches or pull requests

2 participants