Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation fails if repo is cloned with a different name #348

Closed
phanimahesh opened this issue Oct 18, 2015 · 3 comments
Closed

Compilation fails if repo is cloned with a different name #348

phanimahesh opened this issue Oct 18, 2015 · 3 comments
Assignees
@emqplus
Labels
Discussion Enhancement
Milestone
0.13.0

Comments

@phanimahesh
Copy link
Contributor

This is because .. is added to lib_dirs and include_lib is used to include emqttd's own header files. This is a very ugly hack and compilation fails under our CI environment.

Why are we not using include with relative paths instead?
@emqplus emqplus modified the milestones: 0.12.2, 0.13.0 Oct 19, 2015
@emqplus emqplus self-assigned this Oct 19, 2015
@emqplus
Copy link
Contributor

emqplus commented Oct 21, 2015

@phanimahesh, agree that this is a boring issue.

If we use relative path, have to "-inclue("../../../include/emqttd.hrl"). It seems a bit ugly:(

@phanimahesh
Copy link
Contributor Author

If erlang include path is set properly, it should be possible to just do -include("emqttd.hrl"), right?

emqplus pushed a commit that referenced this issue Nov 4, 2015
fix issue #348 -Compilation fails if repo is cloned with a different …
490d7ce 
…name
@emqplus
Copy link
Contributor

emqplus commented Nov 4, 2015

Hi @phanimahesh, I comment the 'lib_dir' in rebar.config:)

@emqplus emqplus closed this as completed Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emqplus emqplus

Labels
Discussion Enhancement
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
2 participants
@emqplus @phanimahesh