Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmbeddedChannel does not fireInactive when closing #4316

Closed
nmittler opened this issue Oct 5, 2015 · 4 comments
Closed

EmbeddedChannel does not fireInactive when closing #4316

nmittler opened this issue Oct 5, 2015 · 4 comments
Assignees
@normanmaurer
Labels
defect
Milestone
4.0.33.Final

Comments

@nmittler
Copy link
Member

nmittler commented Oct 5, 2015

AbstractChannel will fireChannelInactive when closed: https://github.com/netty/netty/blob/master/transport/src/main/java/io/netty/channel/AbstractChannel.java#L662.

However, this is not done for the EmbeddedChannel, so pipelines using EmbeddedChannel will not behave the same way as with other channels.

@Scottmitch @normanmaurer WDYT?
@ninja-
Copy link

ninja- commented Oct 5, 2015

is it because closeExecutor is null for EmbeddedChannel...?

@normanmaurer
Copy link
Member

@nmittler... yes its a bug. working on it, stay tuned.

@normanmaurer normanmaurer self-assigned this Oct 6, 2015
@normanmaurer normanmaurer added this to the 4.0.33.Final milestone Oct 6, 2015
@normanmaurer
Copy link
Member

@ninja- and no its not because of closeExecutor is null.

@Scottmitch
Copy link
Member

@normanmaurer - Thanks for taking this one!

normanmaurer added a commit that referenced this issue Oct 7, 2015
@normanmaurer
[#4316] Ensure pending tasks are run when EmbeddedChannel.close(...) …
0863c9b 
…or disconnect(...) is called.

Motivation:

We missed to run all pending tasks when EmbeddedChannel.close(...) or disconnect(...) was called. Because of this channelInactive(...) / channelUnregistered(...) of the handlers were never called.

Modifications:

Correctly run all pending tasks and cancel all not ready scheduled tasks when close or disconnect was called.

Result:

Correctly run tasks on close / disconnect and have channelInactive(...) / channelUnregistered(...) called.
normanmaurer added a commit that referenced this issue Oct 7, 2015
@normanmaurer
[#4316] Ensure pending tasks are run when EmbeddedChannel.close(...) …
fbaf5d0 
…or disconnect(...) is called.

Motivation:

We missed to run all pending tasks when EmbeddedChannel.close(...) or disconnect(...) was called. Because of this channelInactive(...) / channelUnregistered(...) of the handlers were never called.

Modifications:

Correctly run all pending tasks and cancel all not ready scheduled tasks when close or disconnect was called.

Result:

Correctly run tasks on close / disconnect and have channelInactive(...) / channelUnregistered(...) called.
normanmaurer added a commit that referenced this issue Oct 7, 2015
@normanmaurer
[#4316] Ensure pending tasks are run when EmbeddedChannel.close(...) …
d84eb9b 
…or disconnect(...) is called.

Motivation:

We missed to run all pending tasks when EmbeddedChannel.close(...) or disconnect(...) was called. Because of this channelInactive(...) / channelUnregistered(...) of the handlers were never called.

Modifications:

Correctly run all pending tasks and cancel all not ready scheduled tasks when close or disconnect was called.

Result:

Correctly run tasks on close / disconnect and have channelInactive(...) / channelUnregistered(...) called.
normanmaurer added a commit that referenced this issue Oct 7, 2015
@normanmaurer
[#4316] Ensure pending tasks are run when EmbeddedChannel.close(...) …
845a1a5 
…or disconnect(...) is called.

Motivation:

We missed to run all pending tasks when EmbeddedChannel.close(...) or disconnect(...) was called. Because of this channelInactive(...) / channelUnregistered(...) of the handlers were never called.

Modifications:

Correctly run all pending tasks and cancel all not ready scheduled tasks when close or disconnect was called.

Result:

Correctly run tasks on close / disconnect and have channelInactive(...) / channelUnregistered(...) called.
This was referenced Feb 2, 2021
Merged
Closed
Open
Closed
This was referenced Feb 9, 2021
Open
Closed
Closed
Closed
Closed
Closed
Closed
fixmebot bot referenced this issue in aomsw13/develop_test Apr 12, 2021
@testfixme
Update readme.md
70b8890
pulllock pushed a commit to pulllock/netty that referenced this issue Oct 19, 2023
@normanmaurer
[netty#4316] Ensure pending tasks are run when EmbeddedChannel.close(…
54866b6 
…...) or disconnect(...) is called.

Motivation:

We missed to run all pending tasks when EmbeddedChannel.close(...) or disconnect(...) was called. Because of this channelInactive(...) / channelUnregistered(...) of the handlers were never called.

Modifications:

Correctly run all pending tasks and cancel all not ready scheduled tasks when close or disconnect was called.

Result:

Correctly run tasks on close / disconnect and have channelInactive(...) / channelUnregistered(...) called.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@normanmaurer normanmaurer

Labels
defect
Projects
None yet
Milestone
4.0.33.Final
Development

No branches or pull requests
4 participants
@normanmaurer @ninja- @nmittler @Scottmitch