Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std: Add into_raw_os traits to the OS preludes #27896

Merged
merged 1 commit into from Aug 22, 2015
Merged

std: Add into_raw_os traits to the OS preludes #27896

merged 1 commit into from Aug 22, 2015

Conversation

alexcrichton
Copy link
Member

These traits were mistakenly left out of the OS-specific prelude modules when
they were added.

@alexcrichton
std: Add into_raw_os traits to the OS preludes
708200c 
These traits were mistakenly left out of the OS-specific prelude modules when
they were added.
@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@brson
Copy link
Contributor

brson commented Aug 19, 2015

I'm not clear on when we are allowed to upgrade the various preludes. The main prelude does not get updated. When is it ok to update the I/O and OS preludes?

@sfackler
Copy link
Member

I believe we're okay with updating all non-default preludes because people have to opt-in to glob importing out of them.

@alexcrichton
Copy link
Member Author

Yes strictly speaking this is a breaking change because you could have your own IntoRaw* trait defined locally and this will cause conflicts. In practice, however, I suspect this breaks no code.

@brson brson added the relnotes Marks issues that should be documented in the release notes of the next release. label Aug 19, 2015
@brson
Copy link
Contributor

brson commented Aug 19, 2015

@bors r+

@bors
Copy link
Contributor

bors commented Aug 19, 2015

📌 Commit 708200c has been approved by brson

@bors
Copy link
Contributor

bors commented Aug 22, 2015

⌛ Testing commit 708200c with merge 5fadab6...

@bors
Copy link
Contributor

bors commented Aug 22, 2015

💔 Test failed - auto-linux-32-nopt-t

@alexcrichton
Copy link
Member Author

@bors: retry

On Sat, Aug 22, 2015 at 7:29 AM bors notifications@github.com wrote:

[image: 💔] Test failed - auto-linux-32-nopt-t
http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/6162

—
Reply to this email directly or view it on GitHub
#27896 (comment).

bors added a commit that referenced this pull request Aug 22, 2015
@bors
Auto merge of #27896 - alexcrichton:into-raw-os-prelude, r=brson
8278342 
These traits were mistakenly left out of the OS-specific prelude modules when
they were added.
@bors
Copy link
Contributor

bors commented Aug 22, 2015

⌛ Testing commit 708200c with merge 8278342...

@bors
Copy link
Contributor

bors commented Aug 22, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit 708200c into rust-lang:master Aug 22, 2015
@alexcrichton alexcrichton deleted the into-raw-os-prelude branch September 3, 2015 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alexcrichton @rust-highfive @brson @sfackler @bors