tools: ceph-disk zap should ensure block device #5755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zap only makes sense on a full device and this is verified for
ceph-disk prepare --zap-disk
but not for
ceph-disk zap
Unify the two and add a test to check that it fails as expected when
trying to zap a directory.
http://tracker.ceph.com/issues/11272 Fixes: #11272
Signed-off-by: Loic Dachary <ldachary@redhat.com>
(cherry picked from commit 8e1bcf2)
Conflicts:
src/test/ceph-disk.sh : trivial resolution
ghost
self-assigned this
ghost
pushed a commit
that referenced
this pull request
Sep 2, 2015
Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
The ceph-deploy suite successfully ran two CentOS 6.5 jobs at http://tracker.ceph.com/issues/12701#note-65. The other two failed with what appears to be a problem with dmcrypt (HEALTH_ERR clock skew detected on mon.vpm158; 64 pgs stuck inactive; 64 pgs stuck unclean; no osds; Monitor clock skew detected) that is unrelated to this pull request. |
ghost
pushed a commit
that referenced
this pull request
Sep 2, 2015
ceph-disk zap should ensure block device Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
merged commit
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/12589