Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgw: the arguments 'domain' should not be assigned when return false #5720

Merged
merged 1 commit into from Sep 24, 2015
Merged

rgw: the arguments 'domain' should not be assigned when return false #5720

merged 1 commit into from Sep 24, 2015

Conversation

ghost
Copy link

@ghost ghost commented Aug 30, 2015

@yangruifeng @ldachary
rgw:the arguments 'domain' should not be assigned when return false
a13c7fd 
    Hostnames: [B.A]
    Inputs: [X.BB.A]
    Return: [false]
    Output: [B.A] it is wrong.

Fixes: #12629
Signed-off-by: Ruifeng Yang <149233652@qq.com>
(cherry picked from commit 9420d24)
@ghost ghost self-assigned this Aug 30, 2015
@ghost ghost added this to the hammer milestone Aug 30, 2015
@ghost ghost added bug-fix rgw labels Aug 30, 2015
ghost pushed a commit that referenced this pull request Aug 30, 2015
@ldachary
Merge pull request #5720: the arguments 'domain' should not be assign…
16ac6a3 
…ed when return false

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Aug 30, 2015
@ldachary
Merge pull request #5720: the arguments 'domain' should not be assign…
fa14040 
…ed when return false

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@loic-bot
Copy link

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/7344/

ghost pushed a commit that referenced this pull request Aug 30, 2015
@ldachary
Merge pull request #5720: the arguments 'domain' should not be assign…
9e090f3 
…ed when return false

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Aug 31, 2015
@ldachary
Merge pull request #5720: the arguments 'domain' should not be assign…
0dead22 
…ed when return false

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Aug 31, 2015
@ldachary
Merge pull request #5720: the arguments 'domain' should not be assign…
218780c 
…ed when return false

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Aug 31, 2015
@ldachary
Merge pull request #5720: the arguments 'domain' should not be assign…
bcbbfe4 
…ed when return false

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Sep 1, 2015
@ldachary
Merge pull request #5720: the arguments 'domain' should not be assign…
c512fd0 
…ed when return false

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Sep 2, 2015
@ldachary
Merge pull request #5720: the arguments 'domain' should not be assign…
bbf2baa 
…ed when return false

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost
Copy link
Author

ghost commented Sep 2, 2015

@yehudasa does this backport look good to merge ? It passed a run of the hammer rgw suite ( see http://pulpito.ceph.com/loic-2015-09-01_17:25:32-rgw-hammer-backports---basic-multi/ ).

@ghost ghost assigned yehudasa and unassigned ghost Sep 6, 2015
@ghost
Copy link
Author

ghost commented Sep 13, 2015

@yehudasa ping ?

1 similar comment
@ghost
Copy link
Author

ghost commented Sep 24, 2015

@yehudasa ping ?

yehudasa added a commit that referenced this pull request Sep 24, 2015
@yehudasa
Merge pull request #5720 from dachary/wip-12854-hammer
19e549e 
the arguments 'domain' should not be assigned when return false
@yehudasa yehudasa merged commit 19e549e into ceph:hammer Sep 24, 2015
@ghost ghost changed the title the arguments 'domain' should not be assigned when return false rgw: the arguments 'domain' should not be assigned when return false Sep 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yehudasa yehudasa

Labels
bug-fix rgw
Projects
None yet
Milestone
hammer
3 participants
@loic-bot @yehudasa @yangruifeng