New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rgw: remove trailing :port from host for purposes of subdomain matching #6042
Conversation
@robbat2 could you please git cherry-pick -x abe4ec293d08b0314bf5c081ace2456073f3a22c note the -x that will include a reference to the original commit, which is convenient to figure out where the backport comes from. Thanks ! |
Some clients (ahem, CrossFTP) include the :port in the HTTP_HOST header. Strip it out. Switch req_info field to a std::string and avoid copying it in preprocess. Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit abe4ec2)
e8fbd5f
to
a3afb3f
Compare
@dachary done |
@yehudasa ack, setting DNM for now |
Fixes: ceph#13239 This fixes a regression introduced at commit abe4ec2. The host var is a string, env->get() returns a char pointer, shouldn't pass in NULL. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit 0d5730e) Signed-off-by: Robin H. Johnson <robin.johnson@dreamhost.com>
@yehudasa I added your commit to fix it per issue 13239. |
…rposes of subdomain matching Reviewed-by: Loic Dachary <ldachary@redhat.com>
…rposes of subdomain matching Reviewed-by: Loic Dachary <ldachary@redhat.com>
…rposes of subdomain matching Reviewed-by: Loic Dachary <ldachary@redhat.com>
…rposes of subdomain matching Reviewed-by: Loic Dachary <ldachary@redhat.com>
…rposes of subdomain matching Reviewed-by: Loic Dachary <ldachary@redhat.com>
…rposes of subdomain matching Reviewed-by: Loic Dachary <ldachary@redhat.com>
@yehudasa does this backport look good to merge ? It passed a run of the hammer rgw suite ( see http://tracker.ceph.com/issues/13356#note-5 for details ). |
rgw: remove trailing :port from host for purposes of subdomain matching
http://tracker.ceph.com/issues/13224