osd: PGLog::proc_replica_log: correctly handle case where entries between olog.head and log.tail were split out #5380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the comment, if the overlapping entries between olog.head and log.tail were split out, last_update should be log.tail. Fixes: 11358 Signed-off-by: Samuel Just <sjust@redhat.com> (cherry picked from commit 6561e0d)
Signed-off-by: Samuel Just <sjust@redhat.com> (cherry picked from commit b61e5ae)
Need to fill in log.head, olog.head. Signed-off-by: Samuel Just <sjust@redhat.com> (cherry picked from commit 1e5b220)
If 1'3 is non-divergent, no osd could correctly have created 2'3. Also, proc_replica_log does not add the extra entries from the auth log to the missing set, that happens later on in activate. Signed-off-by: Samuel Just <sjust@redhat.com> (cherry picked from commit 1333b67)
ghost
pushed a commit
that referenced
this pull request
Jul 29, 2015
…ase where entries between olog.head and log.tail were split out Reviewed-by:
|
@liewegas does this backport look good to merge ? It passed a run of the hammer rados suite ( see http://tracker.ceph.com/issues/12701#rados for details ). |
|
👍 |
ghost
pushed a commit
that referenced
this pull request
Aug 30, 2015
…ase where entries between olog.head and log.tail were split out Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 30, 2015
PGLog::proc_replica_log: correctly handle case where entries between olog.head and log.tail were split out Reviewed-by: Sage Weil <sage@redhat.com>
ghost
merged commit 
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/12390