osd: PGLog.cc: 732: FAILED assert(log.log.size() == log_keys_debug.size()) #5763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
ghost
pushed a commit
that referenced
this pull request
Sep 2, 2015
…ze() == log_keys_debug.size()) Reviewed-by: Loic Dachary <ldachary@redhat.com>
There are only two callers of mark_dirty_to who do not pass max, and they are both in the merge_log extending tail path. In that case, we want to include the last version specified in the log writeout. Fix the tail extending code to always specify the last entry added, inclusive. Fixes: #12652 Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit f0ca14d)
|
@liewegas this hammer backport passed a rados suite (see http://tracker.ceph.com/issues/12701#note-62 for the details). Do you think it is ready to be merged ? |
|
👍 |
ghost
pushed a commit
that referenced
this pull request
Sep 7, 2015
osd/PGLog.cc: 732: FAILED assert(log.log.size() == log_keys_debug.size()) Reviewed-by: Sage Weil <sage@redhat.com>
ghost
merged commit
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/12846