New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osd: pg_interval_t::check_new_interval - for ec pool, should not rely on min_size to determine if the PG was active at the interval #5373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guang Yang <yguang@yahoo-inc.com> (cherry picked from commit 466b083)
…ze to determine if the PG was active If the pool's min_size is set improperly, during peering, pg_interval_t::check_new_interval might wrongly determine the PG's state and cause the PG to stuck at down+peering forever Fixes: #12162 Signed-off-by: Guang Yang yguang@yahoo-inc.com (cherry picked from commit 6849274) Conflicts: src/osd/PG.cc because PG::start_peering_interval has an assert that is not found in hammer in the context src/test/osd/types.cc because include/stringify.h is not included by types.cc in hammer
ghost
pushed a commit
that referenced
this pull request
Jul 29, 2015
…pool, should not rely on min_size to determine if the PG was active at the interval Reviewed-by:
@athanatos does this backport look good to merge ? It passed a run of the hammer rados suite ( see http://tracker.ceph.com/issues/12701#rados for details ). Please note that it did not cherry-pick cleanly and the details of the conflict resolution are at cd11b88. I believe they are not significant but it deserves verification. |
ghost
pushed a commit
that referenced
this pull request
Aug 30, 2015
…pool, should not rely on min_size to determine if the PG was active at the interval Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 30, 2015
…pool, should not rely on min_size to determine if the PG was active at the interval Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 30, 2015
…pool, should not rely on min_size to determine if the PG was active at the interval Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 31, 2015
…pool, should not rely on min_size to determine if the PG was active at the interval Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Sep 1, 2015
…pool, should not rely on min_size to determine if the PG was active at the interval Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Sep 2, 2015
…pool, should not rely on min_size to determine if the PG was active at the interval Reviewed-by: Loic Dachary <ldachary@redhat.com>
@liewegas Sam's on vacation, would you mind taking a look at that backport ? |
👍 |
ghost
pushed a commit
that referenced
this pull request
Sep 7, 2015
pg_interval_t::check_new_interval - for ec pool, should not rely on min_size to determine if the PG was active at the interval Reviewed-by: Sage Weil <sage@redhat.com>
ghost
changed the title
pg_interval_t::check_new_interval - for ec pool, should not rely on min_size to determine if the PG was active at the interval
osd: pg_interval_t::check_new_interval - for ec pool, should not rely on min_size to determine if the PG was active at the interval
Sep 13, 2015
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/12489